676793 - Failure in cloning the mozmill-tests repository with Mercurial 1.9 due to injection of peeropts parameter

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[Ilya Nesterov]

User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.107 Safari/535.1

Steps to reproduce:

I am trying to run testrun_functional.py but it cause an exception during cloning repository.



Actual results:


./testrun_functional.py --repository="/home/ilya/work/mozmilTesting/mozmill-tests/" firefox/
*** Cloning repository to '/tmp/tmp8ji_b3.mozmill-tests'
Traceback (most recent call last):
  File "./testrun_functional.py", line 84, in <module>
    main()
  File "./testrun_functional.py", line 81, in main
    run.run()
  File "/home/ilya/work/mozmilTesting/mozmill-automation/libs/testrun.py", line 285, in run
    self.clone_repository()
  File "/home/ilya/work/mozmilTesting/mozmill-automation/libs/testrun.py", line 179, in clone_repository
    e.message)
Exception: Failure in setting up the mozmill-tests repository. 'str' object has no attribute 'get'

here is my environment details:

Linux 2.6.39-pae #1 SMP PREEMPT Tue Jul 26 12:53:04 NOVST 2011 i686 Intel(R) Core(TM)2 Quad CPU Q9400 @ 2.66GHz GenuineIntel GNU/Linux

Mercurial Distributed SCM (version 1.9)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The reason for this failure is the newly introduced peeropts parameter of hg.clone():

http://hg.kublai.com/mercurial/main/file/f4522df38c65/mercurial/hg.py#l177
http://hg.kublai.com/mercurial/main/rev/d976542986d2

Lets see how we can solve this as best.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

Not sure if that is the best approach but due to the API breakage in Mercurial 1.9 I have to differentiate for now between versions >=1.9 and <1.9. Jeff, if you have a better approach in mind, I would kinda like to hear your opinion.

Comment 3

[Jeff Hammel]

Comment on attachment 551022 [details] [diff] [review]
Patch v1

This should work for now

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/38c9c7a800b9

Comment 5

[Ilya Nesterov]

I can confirm that it is fixed now.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Ilya!