Last Comment Bug 676924 - uint64/JSUint64 conflict leading to build failure in dom/base/nsGlobalWindow.cpp and dom/indexedDB/IDBObjectStore.cpp
: uint64/JSUint64 conflict leading to build failure in dom/base/nsGlobalWindow....
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: IndexedDB (show other bugs)
: Trunk
: All OpenBSD
: -- normal (vote)
: mozilla8
Assigned To: Landry Breuil (:gaston)
:
: Hsin-Yi Tsai [:hsinyi]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-05 13:16 PDT by Landry Breuil (:gaston)
Modified: 2012-03-27 01:32 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Potential fix i'm testing (798 bytes, patch)
2011-08-05 13:17 PDT, Landry Breuil (:gaston)
no flags Details | Diff | Splinter Review
second fix, this time replacing uint64 by uint64_t in IDBObjectStore.cpp (1.51 KB, patch)
2011-08-05 14:09 PDT, Landry Breuil (:gaston)
khuey: review+
Details | Diff | Splinter Review

Description Landry Breuil (:gaston) 2011-08-05 13:16:15 PDT
Probably since landing of http://hg.mozilla.org/mozilla-central/rev/6647ba316a10 adding the use of uint64 type, builds fails for me with the following :

/var/buildslave-mozilla/comm-central-amd64/build/mozilla/dom/base/nsGlobalWindow.cpp: In member function 'void PostMessageEvent::SetJSData(JSAutoStructuredCloneBuffer&)':
/var/buildslave-mozilla/comm-central-amd64/build/mozilla/dom/base/nsGlobalWindow.cpp:5944: error: invalid conversion from 'uint64**' to 'JSUint64**'
/var/buildslave-mozilla/comm-central-amd64/build/mozilla/dom/base/nsGlobalWindow.cpp:5944: error:   initializing argument 1 of 'void JSAutoStructuredCloneBuffer::steal(JSUint64**, size_t*, JSUint32*)'
/var/buildslave-mozilla/comm-central-amd64/build/mozilla/dom/base/nsGlobalWindow.cpp: In member function 'virtual nsresult PostMessageEvent::Run()':
/var/buildslave-mozilla/comm-central-amd64/build/mozilla/dom/base/nsGlobalWindow.cpp:5991: error: invalid conversion from 'uint64*' to 'JSUint64*'
/var/buildslave-mozilla/comm-central-amd64/build/mozilla/dom/base/nsGlobalWindow.cpp:5991: error:   initializing argument 1 of 'void JSAutoStructuredCloneBuffer::adopt(JSUint64*, size_t, JSUint32)'
gmake[6]: *** [nsGlobalWindow.o] Error 1

Full log at http://buildbot.rhaalovely.net/builders/comm-central-amd64/builds/96/steps/build/logs/stdio

That's probably related to an uint64/JSUint64 mismatch.. and somewhat related to https://bugzilla.mozilla.org/show_bug.cgi?id=662852
Comment 1 Landry Breuil (:gaston) 2011-08-05 13:17:22 PDT
Created attachment 551137 [details] [diff] [review]
Potential fix i'm testing
Comment 2 Landry Breuil (:gaston) 2011-08-05 13:34:59 PDT
With that patch, the build goes further, but fails later with :

/var/buildslave-mozilla/mozilla-central-amd64/build/dom/indexedDB/IDBObjectStore.cpp: In static member function 'static nsresult mozilla::dom::indexedDB::IDBObjectStore::GetStructuredCloneDataFromStatement(mozIStorageStatement*, PRUint32, JSAutoStructuredCloneBuffer&)':
/var/buildslave-mozilla/mozilla-central-amd64/build/dom/indexedDB/IDBObjectStore.cpp:838: error: invalid conversion from 'const uint64*' to 'const JSUint64*'
/var/buildslave-mozilla/mozilla-central-amd64/build/dom/indexedDB/IDBObjectStore.cpp:838: error:   initializing argument 1 of 'bool JSAutoStructuredCloneBuffer::copy(const JSUint64*, size_t, JSUint32)'
gmake[6]: *** [IDBObjectStore.o] Error 1

Adding another fix on top of the previous...
Comment 3 Landry Breuil (:gaston) 2011-08-05 14:09:21 PDT
Created attachment 551158 [details] [diff] [review]
second fix, this time replacing uint64 by uint64_t in IDBObjectStore.cpp

Build passes fine in dom/base and dom/indexedDB with this patch, will confirm if the full build is ok..
Comment 4 Landry Breuil (:gaston) 2011-08-05 14:45:08 PDT
As can be seen on http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/119, the build is successful with the patch fixing those two issues.. after that, it might not be the perfect patch though.
Comment 5 Landry Breuil (:gaston) 2011-08-05 15:13:26 PDT
And if that can give another data point, it started failing 7 days ago, http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/110 was successful, http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/111 was the first time this particular failure showed.
Comment 6 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-07 19:01:02 PDT
Comment on attachment 551158 [details] [diff] [review]
second fix, this time replacing uint64 by uint64_t in IDBObjectStore.cpp

r=me

Awesome that you have a buildbot setup for OpenBSD.
Comment 7 Landry Breuil (:gaston) 2011-08-08 00:38:40 PDT
Not sure it's the best patch (i'm still lost in all those typedefs) or if it's worth a try run, but setting checkin-needed.

And yes, that buildbot is quite handy, but needs time to be babysitted.. it's very rare to get it all green :)

Note You need to log in before you can comment on or make changes to this bug.