677089 - crash [@ nsAbOSXDirectory::AssertCard]

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Wayne Mery (:wsmwk)]

crash [@ nsAbOSXDirectory::AssertCard]
#82 crash for TB5

none of the crash comments say they were using anything address book related. 
https://crash-stats.mozilla.com/report/list?product=Thunderbird&query_search=signature&query_type=exact&query=nsAbOSXDirectory%3A%3AAssertCard&reason_type=contains&date=08%2F07%2F2011%2007%3A51%3A55&range_value=4&range_unit=weeks&hang_type=any&process_type=all&do_query=1&signature=nsAbOSXDirectory%3A%3AAssertCard

bp-ecf57b53-5df2-4100-9b97-b7e7e2110712 (kk7)
EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
0x0
0	XUL	nsAbOSXDirectory::AssertCard	mailnews/addrbook/src/nsAbOSXDirectory.mm:755
1	XUL	-[ABChangedMonitor ABChanged:]	mailnews/addrbook/src/nsAbOSXDirectory.mm:177
2	Foundation	Foundation@0x10bc4	
3	CoreFoundation	CoreFoundation@0xe8cf	
4	CoreFoundation	CoreFoundation@0x58fff	
5	libobjc.A.dylib	libobjc.A.dylib@0x79a0	
6	Foundation	Foundation@0x289eb	
7	CoreFoundation	CoreFoundation@0x45577	
8	libobjc.A.dylib	libobjc.A.dylib@0x65f2	
9	libobjc.A.dylib	libobjc.A.dylib@0x7bdc	

bp-nsAbOSXDirectory::AssertCard (gmoses)

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I think I see the problem.  For TB <= 6.0, it looks like we're not checking the return value of ConvertToCard, so even if it fails, we go ahead and try to manipulate a NULL pointer:  http://hg.mozilla.org/releases/comm-miramar/diff/e4f4569d451a/mailnews/addrbook/src/nsAbOSXDirectory.mm

Similarly, in TB 7.0, while we capture the return value of CreateCard, we're not actually checking it for success or failure:  http://mxr.mozilla.org/comm-central/source/mailnews/addrbook/src/nsAbOSXDirectory.mm#221

Patch en route.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Whoops - quick correction for that last comment.  Should have been:

I think I see the problem.  For TB <= 5.0, it looks like we're not checking the return value of ConvertToCard, so even if it fails, we go ahead and try to manipulate a NULL pointer:  http://hg.mozilla.org/releases/comm-miramar/diff/e4f4569d451a/mailnews/addrbook/src/nsAbOSXDirectory.mm

Similarly, in TB 6.0+, while we capture the return value of CreateCard, we're not actually checking it for success or failure:  http://mxr.mozilla.org/comm-central/source/mailnews/addrbook/src/nsAbOSXDirectory.mm#221

Patch en route.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Ack, disregard that last comment.  I had it right the first time.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Try build results here:  http://hg.mozilla.org/try-comm-central/rev/83a63bdda052

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 551451 [details] [diff] [review]
Patch v1

Ok, lets try it. I'm a bit concerned that something bad is happening here, and we're going to miss logging it, but I guess we'll have to see if we get users reporting any weird issues.

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/bbf265b99212

Comment 7

[Mark Banner (:standard8)]

Checked into aurora: http://hg.mozilla.org/releases/comm-aurora/rev/c2b9aaff6ff5