Closed
Bug 67726
Opened 25 years ago
Closed 25 years ago
The browser crashes after switching theme
Categories
(Core Graveyard :: Skinability, defect)
Core Graveyard
Skinability
Tracking
(Not tracked)
VERIFIED
WORKSFORME
People
(Reporter: pmac, Assigned: talkback)
References
Details
(Keywords: crash, topcrash, Whiteboard: critical for mozilla 0.8)
Platform: Mac; OS: 9.0 (2001-02-05-12-Mtrunk).
Steps to reproduce:
1. Launch Netscape 6.(The default is Modern)
2. Go to View > Apply theme.., > Classic
NOTE: The brower crashes. The talkback report is coming...
Comment 3•25 years ago
|
||
Switched to classic and then let it crash (using view -> apply theme -> classic)
(using 2001020608 under linux), then restarted the browser and switched back to
modern using the same method, now the View menu is broken. The following error
is given on the command line:
JavaScript error:
chrome://global/content/xulBindings.xml#browser.markupDocumentViewer (getter)
line 0: this.docShell.contentViewer has no properties
ALSO, the file and edit menus don't cause the javascript error, however they do
not show up either. The rest of the menus work.
Comment 4•25 years ago
|
||
pretty high profile. Would like to get a fix for this into 0.8.
Whiteboard: critical for mozilla 0.8
Below here is the takback report:
Trigger Type: Program Crash
Trigger Reason: PowerPC unmapped memory exception
Call Stack: (Signature = .__ptr_glue 76cb6d0c)
.__ptr_glue
nsCSSFrameConstructor::ConstructFrameInternal()
[nsCSSFrameConstructor.cpp,
line 7124]
nsCSSFrameConstructor::ConstructFrame()
[nsCSSFrameConstructor.cpp,
line 7016]
nsCSSFrameConstructor::ProcessChildren()
[nsCSSFrameConstructor.cpp,
line 11145]
nsCSSFrameConstructor::ConstructXULFrame()
[nsCSSFrameConstructor.cpp,
line 5765]
Switched to classic and the browser crashed (using view -> apply theme ->
classic (using 2001-02-06-08-Mtrunk under windows 98).
Then restarted the browser and switched back to
modern using the same method, now the "View and Search" menus are broken.
So here's WHY the crash occurs, nsCSSFrameConstructor.cpp, lines 5757-5762,
if (processChildren || processAnonymousChildren) {
nsCOMPtr<nsIDocument> doc;
aContent->GetDocument(*getter_AddRefs(doc));
nsCOMPtr<nsIBindingManager> bindingManager;
doc->GetBindingManager(getter_AddRefs(bindingManager));
if (processChildren) {
There isn't a check for null on doc after the call
'aContent->GetDocument(*getter_AddRefs(doc));', so if doc is null, kaboom! I
don't have enough expertise in this area of the code to make a proper fix, but
that's the problem.
Have a nice day!
Comment 10•25 years ago
|
||
adding keywords and incresing severity
Severity: normal → blocker
Keywords: crash,
mozilla0.8
Comment 11•25 years ago
|
||
*** Bug 68223 has been marked as a duplicate of this bug. ***
Comment 12•25 years ago
|
||
*** Bug 68223 has been marked as a duplicate of this bug. ***
Comment 13•25 years ago
|
||
Hyatt, this looks suspiciously similar to the crash in 67427, which was caused
by attempting to use a null |document| to retrieve the binding manager. Can
you take a look at this?
Assignee: pierre → hyatt
Comment 14•25 years ago
|
||
*** Bug 68276 has been marked as a duplicate of this bug. ***
Adding topcrash keywords. This is one of the top few crashes in talkback
reports.
Here's the aContent from which we get the null document (it sure *looks* like an
nsXULElement, anyway):
(gdb) p *(nsXULElement*)aContent
$5 = {<nsIXULContent> = {<nsIXMLContent> = {<nsIStyledContent> = {<nsIContent> =
{<nsISupports> = {
_vptr. = 0x40cc4c00}, <No data fields>}, <No data fields>}, <No data
fields>}, <No data fields>}, <nsIDOMXULElement> = {<nsIDOMElement> =
{<nsIDOMNode> = {<nsISupports> = {
_vptr. = 0x40cc4dc0}, <No data fields>}, <No data fields>}, <No data
fields>}, <nsIDOMEventReceiver> = {<nsIDOMEventTarget> = {<nsISupports> = {
_vptr. = 0x40cc4d80}, <No data fields>}, <No data fields>},
<nsIScriptEventHandlerOwner> = {<nsISupports> = {
_vptr. = 0x40cc4d60}, <No data fields>}, <nsIJSScriptObject> =
{<nsIScriptObjectOwner> = {<nsISupports> = {
_vptr. = 0x40cc4d20}, <No data fields>}, <No data fields>},
<nsIChromeEventHandler> = {<nsISupports> = {_vptr. = 0x40cc4cf8}, <No data
fields>},
static gRefCnt = 1340, static gRDFService = 0x812d458,
static gNameSpaceManager = 0x8235638, static gXULUtils = 0x8188db0,
static kNameSpaceID_RDF = 10, static kNameSpaceID_XUL = 6, mRefCnt = 3,
_mOwningThread = 0x80621d8, mPrototype = 0x0, mDocument = 0x0,
mParent = 0x0, mChildren = {mImpl = 0x421f55d0, _vptr. = 0x40190480},
mListenerManager = {mRawPtr = 0x0}, mScriptObject = 0x0, mContentId = 0,
mLazyState = 0, mBindingParent = 0x4218b5a8, mSlots = 0x421baf58}
Keywords: topcrash
Comment 16•25 years ago
|
||
no longer seeing this on commercial builds:
windows 2001-02-09-06-mtrunk
linux 2001-02-09-06-mtrunk mac
2001-02-09-04-mtrunk
markign wfm
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
Comment 17•25 years ago
|
||
Under Linux 2001-02-09-06 The system doesn't crash for me when switching to
Classic mode from Modern mode, however, when switching between either mode the
View Menu is broken in both cases after applying the skin, and when moving to
classic mode, the search menu is also broken.
Same error I had mentioned before still occurs:
JavaScript error:
chrome://global/content/xulBindings.xml#browser.markupDocumentViewer (getter)
line 0: this.docShell.contentViewer has no properties
I filed the problem of the View menu being broken after theme switch as bug 68492.
Updated•25 years ago
|
Keywords: mozilla0.8
Comment 20•25 years ago
|
||
Moving all the Works For Me bugs to talkback user account for future reference.
Assignee: hyatt → talkback
Status: VERIFIED → NEW
Comment 21•25 years ago
|
||
We are gathering all the Resolved and WFM bugs which are happened to be topcrash
bugs and assigning it to talkback. I am marking all of them as RESOLVED WFM.
Status: NEW → RESOLVED
Closed: 25 years ago → 25 years ago
| Reporter | ||
Comment 22•25 years ago
|
||
workforme on all platforms (branch build: 2001-06-28-23-0.9.2).
Status: RESOLVED → VERIFIED
Updated•18 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•