677340 - Stop returning nsCOMPtr by value in various places

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

I believe you owe me a review

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1 (diff -w)

Comment 2

[(no longer active)]

Comment on attachment 551531 [details] [diff] [review]
Patch v1

Review of attachment 551531 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditor.cpp
@@ +941,2 @@
>    if (NS_FAILED(aNode->GetParentNode(getter_AddRefs(p))))  // no parent, ran off top of tree
> +    return NULL;

Use nsnull, please.

@@ +1061,3 @@
>            {
> +            // add range to the list if it doesn't overlap with the previous range
> +            bool addRange = true;

I'm gonna ignore you sneaking in this change, because I like it.  It just makes me sad that you didn't do the same for isNotInlineOrText.  ;-)

@@ +1115,5 @@
>  
>    nsresult rv;
>    nsCOMPtr<nsIContentIterator> iter =
>         do_CreateInstance("@mozilla.org/content/post-content-iterator;1", &rv);
> +  NS_ENSURE_SUCCESS(rv, NULL);

nsnull.

@@ +1151,5 @@
>      else
>        iter->Prev();
>    }
>    
> +  return NULL;

nsnull.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Ehsan Akhgari [:ehsan] from comment #2)
> Comment on attachment 551531 [details] [diff] [review]
> @@ +1061,3 @@
> >            {
> > +            // add range to the list if it doesn't overlap with the previous range
> > +            bool addRange = true;
> 
> I'm gonna ignore you sneaking in this change, because I like it.  It just
> makes me sad that you didn't do the same for isNotInlineOrText.  ;-)

I would have, but it's used as a PRBool* outparam.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/0a8dcfddf43f