Closed
Bug 677358
Opened 13 years ago
Closed 13 years ago
Add cycle collector button to about:memory
Categories
(Toolkit :: about:memory, defect)
Toolkit
about:memory
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
(Whiteboard: [MemShrink:P3])
Attachments
(1 file, 2 obsolete files)
2.60 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
Now that Bug 625302 has landed, it should be possible to add a "CC" button to about memory that runs the cycle collector without (necessarily) running the GC. This is mostly a fiddly option that won't matter much, but it could be handy.
Another thing to consider would be to add a button to do a CC that does a heap dump, as outlined here: https://wiki.mozilla.org/Performance:Leak_Tools#Cycle_collector_heap_dump I don't know if I am totally comfortable with a button that you click that dumps out a file, but the capability is already there to some extent.
Assignee | ||
Comment 1•13 years ago
|
||
Oh, and this could replace the GC+CC button that currently exists.
Updated•13 years ago
|
Assignee: nobody → continuation
Whiteboard: [MemShrink] → [MemShrink:P3]
Assignee | ||
Comment 2•13 years ago
|
||
completely untested
Assignee | ||
Comment 3•13 years ago
|
||
Oops, forgot to update the description and remove the comment about why we don't have a pure CC button.
Attachment #552703 -
Attachment is obsolete: true
Assignee | ||
Comment 4•13 years ago
|
||
changed the name of the function called to doGC(), instead of doGlobalCC().
I tested this a little. I used javascript.options.mem.log to confirm that clicking on the CC button causes a CC and no GC.
Attachment #552705 -
Attachment is obsolete: true
Attachment #552722 -
Flags: review?(nnethercote)
Updated•13 years ago
|
Attachment #552722 -
Flags: review?(nnethercote) → review+
Comment 5•13 years ago
|
||
Try run for 4432748009fe is complete.
Detailed breakdown of the results available here:
http://tbpl.mozilla.org/?tree=Try&rev=4432748009fe
Results (out of 170 total builds):
success: 153
warnings: 15
failure: 2
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/amccreight@mozilla.com-4432748009fe
Assignee | ||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•