Closed Bug 677358 Opened 10 years ago Closed 10 years ago

Add cycle collector button to about:memory

Categories

(Toolkit :: about:memory, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

(Whiteboard: [MemShrink:P3])

Attachments

(1 file, 2 obsolete files)

Now that Bug 625302 has landed, it should be possible to add a "CC" button to about memory that runs the cycle collector without (necessarily) running the GC.  This is mostly a fiddly option that won't matter much, but it could be handy.

Another thing to consider would be to add a button to do a CC that does a heap dump, as outlined here: https://wiki.mozilla.org/Performance:Leak_Tools#Cycle_collector_heap_dump  I don't know if I am totally comfortable with a button that you click that dumps out a file, but the capability is already there to some extent.
Depends on: 625302
Whiteboard: [MemShrink]
Oh, and this could replace the GC+CC button that currently exists.
Assignee: nobody → continuation
Whiteboard: [MemShrink] → [MemShrink:P3]
completely untested
Oops, forgot to update the description and remove the comment about why we don't have a pure CC button.
Attachment #552703 - Attachment is obsolete: true
changed the name of the function called to doGC(), instead of doGlobalCC().

I tested this a little.  I used javascript.options.mem.log to confirm that clicking on the CC button causes a CC and no GC.
Attachment #552705 - Attachment is obsolete: true
Attachment #552722 - Flags: review?(nnethercote)
Depends on: 654041
Attachment #552722 - Flags: review?(nnethercote) → review+
Try run for 4432748009fe is complete.
Detailed breakdown of the results available here:
    http://tbpl.mozilla.org/?tree=Try&rev=4432748009fe
Results (out of 170 total builds):
    success: 153
    warnings: 15
    failure: 2
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/amccreight@mozilla.com-4432748009fe
http://hg.mozilla.org/mozilla-central/rev/64b4ec7bfb43
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.