677358 - Add cycle collector button to about:memory

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Andrew McCreight [:mccr8]]

Now that Bug 625302 has landed, it should be possible to add a "CC" button to about memory that runs the cycle collector without (necessarily) running the GC.  This is mostly a fiddly option that won't matter much, but it could be handy.

Another thing to consider would be to add a button to do a CC that does a heap dump, as outlined here: https://wiki.mozilla.org/Performance:Leak_Tools#Cycle_collector_heap_dump  I don't know if I am totally comfortable with a button that you click that dumps out a file, but the capability is already there to some extent.

Comment 1

[Andrew McCreight [:mccr8]]

Oh, and this could replace the GC+CC button that currently exists.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: change the GC+CC button to a CC button in about:memory

completely untested

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: change the GC+CC button to a CC button in about:memory

Oops, forgot to update the description and remove the comment about why we don't have a pure CC button.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: change the GC+CC button to a CC button in about:memory

changed the name of the function called to doGC(), instead of doGlobalCC().

I tested this a little.  I used javascript.options.mem.log to confirm that clicking on the CC button causes a CC and no GC.

Comment 5

[Mozilla RelEng Bot]

Try run for 4432748009fe is complete.
Detailed breakdown of the results available here:
    http://tbpl.mozilla.org/?tree=Try&rev=4432748009fe
Results (out of 170 total builds):
    success: 153
    warnings: 15
    failure: 2
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-4432748009fe

Comment 6

[Andrew McCreight [:mccr8]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/64b4ec7bfb43

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/64b4ec7bfb43