Closed Bug 677418 Opened 8 years ago Closed 8 years ago

Remove unused nsNSSComponent::GetNSSCipherIDFromPrefString

Categories

(Core :: Security: PSM, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #677409 +++
+++ This bug was initially created as a clone of Bug #593077 +++

The next time we make a backward-incompatible change to nsNSSComponent, we should also remove the GetNSSCipherIDFromPrefString method, which will be unused after bug 677409 is fixed. I am not including the change to the interface ID in the patch because that change should be done in the patch this one rides along with.
Attachment #551620 - Flags: review?(kaie)
Comment on attachment 551620 [details] [diff] [review]
remove nsNSSComponent::GetNSSCipherIDFromPrefString

I don't think we need to change any UUIDs or contract IDs. AFAICT this function isn't declared in any IDLs, it's just a local helper function, and fine to remove.

r=kaie
Attachment #551620 - Attachment description: remove nsNSSComponent::GetNSSCipherIDFromPrefString - do not check in without a patch that also changes the contract ID → remove nsNSSComponent::GetNSSCipherIDFromPrefString
Attachment #551620 - Flags: review?(kaie) → review+
http://hg.mozilla.org/mozilla-central/rev/a23a0490b620
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Assignee: nobody → brian
You need to log in before you can comment on or make changes to this bug.