677427 - xpcshell test netwerk/test/unit/test_bug650955.js fails on Android

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Geoff Brown [:gbrown]]

With patches for bug 668349 and 668351, xpcshell tests can be run on an Android device, and the majority of tests pass. 

However, netwerk/test/unit/test_bug650955.js consistently fails when run on Android.

(I thought this might be related to intermittent failures of this test on Mac, and tried applying the patch from Bug 667593, but that did not help -- the test failed with identical error messages).

Comment 1

[Geoff Brown [:gbrown]]

Attachment: log showing xpcshell output for test_bug650955.js on Android

Comment 2

[Geoff Brown [:gbrown]]

Attachment: necko log of failed test run on Android

Comment 3

[Geoff Brown [:gbrown]]

The memory cache tests pass, but the disk cache tests fail. The problem is that the preference browser.cache.disk.capacity has a default of 0 in Fennec, so the disk cache is still effectively disabled, even after browser.cache.disk.enable is set to true.

Comment 4

[Geoff Brown [:gbrown]]

Attachment: patch for review

test_bug650955.js passes reliably with this patch. If enabling the disk cache and disk cache capacity is 0, capacity is set to 1024 (an arbitrary, small cache). To guard against a similar issue arising with the memory cache, a similar check is made for the memory cache capacity, when enabling the memory cache.

Comment 5

[Geoff Brown [:gbrown]]

Attachment: patch for review

I noticed a problem with the previous patch: If either of the capacity prefs does not exist, the test fails. Now updated to allow for non-existent prefs.

Comment 6

[Bjarne (:bjarne)]

Comment on attachment 555265 [details] [diff] [review]
patch for review

Review of attachment 555265 [details] [diff] [review]:
-----------------------------------------------------------------

Nice

Comment 7

[Daniel Holbert [:dholbert]]

Comment on attachment 555265 [details] [diff] [review]
patch for review

I fixed end-of-line whitespace...
>+        if (memDevice) {
>+            try {
>+                cap = prefService.getIntPref("browser.cache.memory.capacity");
>+            } 
...here -------^

>+        if (diskDevice) {
>+            try {
>+                cap = prefService.getIntPref("browser.cache.disk.capacity");
>+            } 
...and here ---^

and pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/bc6b53c4e931

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/bc6b53c4e931