Closed
Bug 677466
Opened 13 years ago
Closed 13 years ago
Add memory reporter for the atoms table
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
(Blocks 1 open bug)
Details
(Whiteboard: [MemShrink:P2])
Attachments
(1 file)
|
5.42 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
DMD found that the atoms table is quite big. E.g. after loading Gmail it's just over 2MB (1.5%) on my Linux64 box.
This patch also adds a "runtime" reporter, which is 282KB on my box. Not that big, but doesn't hurt to include it.
Attachment #551685 -
Flags: review?(luke)
|
Assignee | |
Updated•13 years ago
|
Blocks: DarkMatter
Whiteboard: [MemShrink]
|
|
||
Comment 1•13 years ago
|
||
Comment on attachment 551685 [details] [diff] [review]
patch
Review of attachment 551685 [details] [diff] [review]:
-----------------------------------------------------------------
On the subject of the large atom state, it would be interested to measure how many of those atoms have been "interned" since interned strings are never swept and thus could be a source of leaks. This is pretty easy to derive (see js_TraceAtomState).
Attachment #551685 -
Flags: review?(luke) → review+
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P2]
|
||
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•