Closed Bug 677466 Opened 8 years ago Closed 8 years ago

Add memory reporter for the atoms table

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla8

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 file)

patch
5.42 KB, patch
luke
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
DMD found that the atoms table is quite big.  E.g. after loading Gmail it's just over 2MB (1.5%) on my Linux64 box.

This patch also adds a "runtime" reporter, which is 282KB on my box.  Not that big, but doesn't hurt to include it.
Attachment #551685 - Flags: review?(luke)
Blocks: DarkMatter
Whiteboard: [MemShrink]
Comment on attachment 551685 [details] [diff] [review]
patch

Review of attachment 551685 [details] [diff] [review]:
-----------------------------------------------------------------

On the subject of the large atom state, it would be interested to measure how many of those atoms have been "interned" since interned strings are never swept and thus could be a source of leaks.  This is pretty easy to derive (see js_TraceAtomState).
Attachment #551685 - Flags: review?(luke) → review+
Whiteboard: [MemShrink] → [MemShrink:P2]
http://hg.mozilla.org/mozilla-central/rev/b391327ee19a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.