Closed Bug 677642 Opened 8 years ago Closed 8 years ago

[css3-mediaqueries] media queries defines <resolution> as accepting <number>, not just <integer>

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

http://www.w3.org/TR/css3-mediaqueries/#values says <resolution> is <number> (not <integer>) followed by a unit identifier.  (At the time I implemented it I think this was vague, and I implemented <integer>.)
Attached patch patchSplinter Review
Attachment #551847 - Flags: review?(bzbarsky)
Yeah, I committed the tests in July 2008 (which means I wrote them earlier):

https://hg.mozilla.org/mozilla-central/rev/bb091bc06282

Anne landed text in the spec just before I did that, defining it as <integer> in:

revision 1.24
date: 2008/06/12 14:16:20;  author: avankest;  state: Exp;  lines: +21 -21
define <ratio> to allow whitespace around '/' in aspect-ratio and device-aspect-ratio

and then changed it to <number> in:

revision 1.25
date: 2008/08/26 10:45:50;  author: avankest;  state: Exp;  lines: +16 -9
work around bugs in the preprocessor; make grid:2 an error; add notes about not affecting HTML and all; <resolution> takes numbers
Comment on attachment 551847 [details] [diff] [review]
patch

r=me
Attachment #551847 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/5ed6a44da1a8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Keywords: dev-doc-needed
A note in "Firefox 8 for Developers" doesn't make dev-doc-complete.

Updating  https://developer.mozilla.org/en/CSS/media_queries#resolution
should be considered, at least.
You need to log in before you can comment on or make changes to this bug.