677642 - [css3-mediaqueries] media queries defines <resolution> as accepting <number>, not just <integer>

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://www.w3.org/TR/css3-mediaqueries/#values says <resolution> is <number> (not <integer>) followed by a unit identifier.  (At the time I implemented it I think this was vague, and I implemented <integer>.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.csswg.org/test/rev/c0aa90be90ad

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, I committed the tests in July 2008 (which means I wrote them earlier):

https://hg.mozilla.org/mozilla-central/rev/bb091bc06282

Anne landed text in the spec just before I did that, defining it as <integer> in:

revision 1.24
date: 2008/06/12 14:16:20;  author: avankest;  state: Exp;  lines: +21 -21
define <ratio> to allow whitespace around '/' in aspect-ratio and device-aspect-ratio

and then changed it to <number> in:

revision 1.25
date: 2008/08/26 10:45:50;  author: avankest;  state: Exp;  lines: +16 -9
work around bugs in the preprocessor; make grid:2 an error; add notes about not affecting HTML and all; <resolution> takes numbers

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 551847 [details] [diff] [review]
patch

r=me

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ed6a44da1a8

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/5ed6a44da1a8

Comment 7

[j.j.]

A note in "Firefox 8 for Developers" doesn't make dev-doc-complete.

Updating  https://developer.mozilla.org/en/CSS/media_queries#resolution
should be considered, at least.

Comment 8

[Eric Shepherd [:sheppy]]

Docs updated:

https://developer.mozilla.org/en/CSS/number
https://developer.mozilla.org/en/CSS/Media_queries#resolution