[css3-mediaqueries] media queries defines <resolution> as accepting <number>, not just <integer>

RESOLVED FIXED in mozilla8

Status

()

Core
CSS Parsing and Computation
P3
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({dev-doc-complete})

Trunk
mozilla8
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
http://www.w3.org/TR/css3-mediaqueries/#values says <resolution> is <number> (not <integer>) followed by a unit identifier.  (At the time I implemented it I think this was vague, and I implemented <integer>.)
(Assignee)

Comment 1

6 years ago
Created attachment 551847 [details] [diff] [review]
patch
Attachment #551847 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

6 years ago
https://hg.csswg.org/test/rev/c0aa90be90ad
(Assignee)

Comment 3

6 years ago
Yeah, I committed the tests in July 2008 (which means I wrote them earlier):

https://hg.mozilla.org/mozilla-central/rev/bb091bc06282

Anne landed text in the spec just before I did that, defining it as <integer> in:

revision 1.24
date: 2008/06/12 14:16:20;  author: avankest;  state: Exp;  lines: +21 -21
define <ratio> to allow whitespace around '/' in aspect-ratio and device-aspect-ratio

and then changed it to <number> in:

revision 1.25
date: 2008/08/26 10:45:50;  author: avankest;  state: Exp;  lines: +16 -9
work around bugs in the preprocessor; make grid:2 an error; add notes about not affecting HTML and all; <resolution> takes numbers

Comment 4

6 years ago
Comment on attachment 551847 [details] [diff] [review]
patch

r=me
Attachment #551847 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ed6a44da1a8
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/5ed6a44da1a8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Keywords: dev-doc-needed

Updated

6 years ago
Keywords: dev-doc-needed → dev-doc-complete

Comment 7

6 years ago
A note in "Firefox 8 for Developers" doesn't make dev-doc-complete.

Updating  https://developer.mozilla.org/en/CSS/media_queries#resolution
should be considered, at least.
Keywords: dev-doc-complete → dev-doc-needed
Docs updated:

https://developer.mozilla.org/en/CSS/number
https://developer.mozilla.org/en/CSS/Media_queries#resolution
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.