Closed Bug 677644 Opened 8 years ago Closed 8 years ago

Fix c++0x initializer list error found by clang

Categories

(Toolkit :: Crash Reporting, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file)

Attached patch add castSplinter Review
The process_id field is unsigned, so we need this cast in c++0x. Let me know if you would like me to try to make the field signed instead.
See http://llvm.org/viewvc/llvm-project/?view=rev&revision=136181
for more information.
Attachment #551848 - Flags: review?(mh+mozilla)
Attachment #551848 - Flags: review?(mh+mozilla) → review?(ted.mielczarek)
Committed Breakpad r825.
Assignee: nobody → respindola
Comment on attachment 551848 [details] [diff] [review]
add cast

Feel free to land this in m-c as well.
Attachment #551848 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/2012711170aa

It looks like the commit message in the attached patch included a chunk of the bug description. ("The process_id field is unsigned, so we need this cast in c++0x. Let me know if you would like me to try to make the field signed instead.
See http://llvm.org/viewvc/llvm-project/?view=rev&revision=136181
for more information.")

I trimmed it, but it'd be helpful if you could make sure the commit message in checkin-needed patches was more commit-message-ish. :)
Keywords: checkin-needed
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/2012711170aa
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.