Closed
Bug 677648
Opened 14 years ago
Closed 14 years ago
Fix c++0x initializer list error found by clang
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(1 file)
|
1.59 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
The mAdvance field of DetailedGlyph is a PRInt32. Since the advance
variable is used in
DetailedGlyph detail = {glyphIndex, advance, 0, 0};
it should be a PRInt32 instead of a PRUint32. Let me know if I should try
to change the field instead.
Attachment #551857 -
Flags: review?(mh+mozilla)
|
||
Updated•14 years ago
|
Attachment #551857 -
Flags: review?(mh+mozilla) → review?(roc)
Attachment #551857 -
Flags: review?(roc) → review+
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Updated•14 years ago
|
Assignee: nobody → respindola
|
||
Comment 1•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Version: unspecified → Trunk
|
|
||
Updated•14 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•