677667 - [Mac default] Make use of the new nsNativeTheme toolbarbutton styling in DM and PageInfo

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

Attachment: v1.0

Toolbar buttons can now be drawn wth of CoreUI (bug 672050). This style is suitable for 'buttons' in DM and pageInfo (we fake it a bit here).

I actually thought bug 672050 wasn't going to get fixed for Mozilla8 (see https://bugzilla.mozilla.org/show_bug.cgi?id=674368#c0), but I was wrong.

I think we need to test this on Lion... But I don't have Lion.

Comment 1

[Stefan [:stefanh]]

Attachment: v1.1

Noted that the "toolbar" in pageInfo was slightly higher than it should be. I also now use a min-height for the windowdragbox (same as used in toolbars). We could skip that, since it will only have effect if someone does bad things with the tabs (content in the #tabs element and its padding/margin sizes the box to the correct height).

This patch (and the previous one) also contains some clean-up and the remaining tab style rules are now positioned straight after the only remaining #tabs rule. I also re-positioned and changed the size of the clearListButton (now it looks the same as the FF equivalent).

Comment 2

[Stefan [:stefanh]]

Comment on attachment 551885 [details] [diff] [review]
v1.1

I will of course not land this until I have tested it on Lion (I should be able to do that soon).

Comment 3

[Stefan [:stefanh]]

Fwiw, I tested the patch on Lion and I think it looks OK. The only thing that differ from the eq viewbuttons in Firefox's pageinfo window is that when you click a tab the background color of the tab will be much darker compared to when you click a viewbutton. I think we can live with that, though.

Comment 4

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/53896297893a