The default bug view has changed. See this FAQ.

Remove unique_pointer from typelib code

RESOLVED FIXED in mozilla9

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: emorley)

Tracking

({dev-doc-complete})

Trunk
mozilla9
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

It's completely unused.
(Assignee)

Comment 1

6 years ago
Created attachment 554032 [details] [diff] [review]
Patch v1
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #554032 - Flags: review?(khuey)
Comment on attachment 554032 [details] [diff] [review]
Patch v1

Does typelib.py not need adjustments here?
Attachment #554032 - Flags: review?(khuey) → review+
(Assignee)

Comment 3

6 years ago
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2)
> Does typelib.py not need adjustments here?

Ah yes, the comments there can be removed too. Didn't show up in my local grep since I ran it from xpcom/typelib/ only, since MXR doesn't show occurrences in typelib.py due to out of date indexes :-(
(Assignee)

Comment 4

6 years ago
Created attachment 554091 [details] [diff] [review]
Patch v1.1

http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=da307e32d0c2
Attachment #554032 - Attachment is obsolete: true
(Assignee)

Comment 5

6 years ago
New try push due to random tree breakage that was going on at the time:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=f701ded4c303

(That will teach me to pull from m-c tip when sending to try)

Like the other checkin-needed's I'll likely just do these myself once IT flip my L3 bits in bug 680448.
Flags: in-testsuite-
Keywords: checkin-needed
Version: unspecified → Trunk
http://hg.mozilla.org/integration/mozilla-inbound/rev/d5514e9dd45c
Keywords: checkin-needed
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/d5514e9dd45c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Keywords: dev-doc-needed
Added a note to Firefox 9 for developers; since unique pointers appear never to have been fully implemented (let alone used), they were never documented, so this seems to be the most that needs doing (indeed it probably doesn't need mentioning at all).
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.