Closed Bug 677864 Opened 13 years ago Closed 13 years ago

Components.results class description is wrong

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: arno, Assigned: arno)

Details

Attachments

(3 files)

testcase
390 bytes, text/html
Details
patch proposal
6.65 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
patch fixing tests
6.48 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
Attached file testcase — 
Hi,
nsXPCComponents_Results class description is wrong.
See testcase.
Attached patch patch proposal — — Splinter Review 

    
  

        Attachment #552082 -
        Flags: review?(mrbkap)

        Attachment #552082 -
        Flags: review?(mrbkap) → review+
Assignee: nobody → arno

    
    

    
  


  
It looks like test does not pass. I though I had submitted a correct test, but I did not qrefresh or whatever. Here is the same patch with updated test.

        Attachment #553898 -
        Flags: review?

    
  

        Attachment #553898 -
        Flags: review? → review?(mrbkap)

    
    

    
  
Backed it out of inbound because of the test failure.
Whiteboard: [inbound]

    
  

        Attachment #553898 -
        Flags: review?(mrbkap)

    
    

    
  
Try run for 1149bed204f1 is complete.
Detailed breakdown of the results available here:
    http://tbpl.mozilla.org/?tree=Try&rev=1149bed204f1
Results (out of 244 total builds):
    exception: 2
    success: 221
    warnings: 20
    failure: 1
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/arno@renevier.net-1149bed204f1

    
    

    
  
Comment on attachment 553898 [details] [diff] [review]
patch fixing tests

correct link is http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=1149bed204f1

        Attachment #553898 -
        Flags: review?(mrbkap)

        Attachment #553898 -
        Flags: review?(mrbkap) → review+

    
  
Keywords: checkin-needed

    
    

    
  
Pushed to inbound.
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/77704e4f395b
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Version: unspecified → Trunk

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: