The default bug view has changed. See this FAQ.

symbolstore.py should use objcopy from the NDK to copy debug info

RESOLVED FIXED in Firefox 8

Status

()

Toolkit
Breakpad Integration
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ted, Assigned: glandium)

Tracking

Trunk
mozilla10
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox8 fixed, firefox9 fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Currently we don't get native debug symbols for our Android builds on the symbol server because we try to use the system objcopy on our binaries, and it chokes:
objcopy: Unable to recognise the format of the input file `./dist/bin/libxul.so'

We should be using the objcopy from the NDK instead:
android-ndk-r4c/build/prebuilt/linux-x86/arm-eabi-4.4.0/arm-eabi/bin/objcopy
android-ndk-r4c/build/prebuilt/linux-x86/arm-eabi-4.4.0/bin/arm-eabi-objcopy
(Assignee)

Comment 1

6 years ago
Created attachment 564194 [details] [diff] [review]
Use objcopy from the NDK in symbolstore.py
Attachment #564194 - Flags: review?(ted.mielczarek)
(Reporter)

Comment 2

6 years ago
Comment on attachment 564194 [details] [diff] [review]
Use objcopy from the NDK in symbolstore.py

Review of attachment 564194 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +444,5 @@
>      MOZ_CHROME_FILE_FORMAT=omni
>      ZLIB_DIR=yes
>      ;;
> +*)
> +    OBJCOPY=objcopy

Do we want to AC_PATH_PROGS this?
Attachment #564194 - Flags: review?(ted.mielczarek) → review+
(Reporter)

Updated

6 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 3

6 years ago
Comment on attachment 564194 [details] [diff] [review]
Use objcopy from the NDK in symbolstore.py

This could be something we'd want to land on beta and aurora, as it will allow us to download debuginfo for use with gdb on releases.
Attachment #564194 - Flags: approval-mozilla-beta?
Attachment #564194 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/348e16153987
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10

Updated

6 years ago
Attachment #564194 - Flags: approval-mozilla-beta?
Attachment #564194 - Flags: approval-mozilla-beta+
Attachment #564194 - Flags: approval-mozilla-aurora?
Attachment #564194 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/a929601e7a9e/
http://hg.mozilla.org/releases/mozilla-beta/rev/f1f0a546a33d/

Updated

6 years ago
status-firefox8: --- → fixed
status-firefox9: --- → fixed
You need to log in before you can comment on or make changes to this bug.