Closed Bug 677897 Opened 8 years ago Closed 8 years ago

symbolstore.py should use objcopy from the NDK to copy debug info

Categories

(Toolkit :: Crash Reporting, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10
Tracking Status
firefox8 --- fixed
firefox9 --- fixed

People

(Reporter: ted, Assigned: glandium)

References

()

Details

Attachments

(1 file)

Currently we don't get native debug symbols for our Android builds on the symbol server because we try to use the system objcopy on our binaries, and it chokes:
objcopy: Unable to recognise the format of the input file `./dist/bin/libxul.so'

We should be using the objcopy from the NDK instead:
android-ndk-r4c/build/prebuilt/linux-x86/arm-eabi-4.4.0/arm-eabi/bin/objcopy
android-ndk-r4c/build/prebuilt/linux-x86/arm-eabi-4.4.0/bin/arm-eabi-objcopy
Comment on attachment 564194 [details] [diff] [review]
Use objcopy from the NDK in symbolstore.py

Review of attachment 564194 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +444,5 @@
>      MOZ_CHROME_FILE_FORMAT=omni
>      ZLIB_DIR=yes
>      ;;
> +*)
> +    OBJCOPY=objcopy

Do we want to AC_PATH_PROGS this?
Attachment #564194 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → mh+mozilla
Comment on attachment 564194 [details] [diff] [review]
Use objcopy from the NDK in symbolstore.py

This could be something we'd want to land on beta and aurora, as it will allow us to download debuginfo for use with gdb on releases.
Attachment #564194 - Flags: approval-mozilla-beta?
Attachment #564194 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/348e16153987
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Attachment #564194 - Flags: approval-mozilla-beta?
Attachment #564194 - Flags: approval-mozilla-beta+
Attachment #564194 - Flags: approval-mozilla-aurora?
Attachment #564194 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.