Closed
Bug 677897
Opened 13 years ago
Closed 13 years ago
symbolstore.py should use objcopy from the NDK to copy debug info
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: ted, Assigned: glandium)
References
()
Details
Attachments
(1 file)
5.25 KB,
patch
|
ted
:
review+
christian
:
approval-mozilla-aurora+
christian
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Currently we don't get native debug symbols for our Android builds on the symbol server because we try to use the system objcopy on our binaries, and it chokes: objcopy: Unable to recognise the format of the input file `./dist/bin/libxul.so' We should be using the objcopy from the NDK instead: android-ndk-r4c/build/prebuilt/linux-x86/arm-eabi-4.4.0/arm-eabi/bin/objcopy android-ndk-r4c/build/prebuilt/linux-x86/arm-eabi-4.4.0/bin/arm-eabi-objcopy
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #564194 -
Flags: review?(ted.mielczarek)
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 564194 [details] [diff] [review] Use objcopy from the NDK in symbolstore.py Review of attachment 564194 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +444,5 @@ > MOZ_CHROME_FILE_FORMAT=omni > ZLIB_DIR=yes > ;; > +*) > + OBJCOPY=objcopy Do we want to AC_PATH_PROGS this?
Attachment #564194 -
Flags: review?(ted.mielczarek) → review+
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 564194 [details] [diff] [review] Use objcopy from the NDK in symbolstore.py This could be something we'd want to land on beta and aurora, as it will allow us to download debuginfo for use with gdb on releases.
Attachment #564194 -
Flags: approval-mozilla-beta?
Attachment #564194 -
Flags: approval-mozilla-aurora?
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/348e16153987
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Attachment #564194 -
Flags: approval-mozilla-beta?
Attachment #564194 -
Flags: approval-mozilla-beta+
Attachment #564194 -
Flags: approval-mozilla-aurora?
Attachment #564194 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/a929601e7a9e/ http://hg.mozilla.org/releases/mozilla-beta/rev/f1f0a546a33d/
status-firefox8:
--- → fixed
status-firefox9:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•