JS shell: version(4096) asserts

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Trunk
mozilla8
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 552098 [details] [diff] [review]
v1

http://quotes.burntelectrons.org/4833
Assignee: general → jorendorff
Attachment #552098 - Flags: review?(cdleary)
(Assignee)

Comment 2

6 years ago
The essential thing is to reject values >= 4096 with an exception; the rest is just me trying to get Version use the API correctly.

Incidentally that test where I added a Number() call was never doing what it thought it was doing, because version() would just ignore the string arguments.

Updated

6 years ago
Duplicate of this bug: 652806
Attachment #552098 - Flags: review?(cdleary) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/7ae3174c57ff
Whiteboard: [inbound]
Merged:
http://hg.mozilla.org/mozilla-central/rev/7ae3174c57ff
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Version: Other Branch → Trunk
You need to log in before you can comment on or make changes to this bug.