Last Comment Bug 677937 - Add a --enable-webapi configure option
: Add a --enable-webapi configure option
Status: RESOLVED WONTFIX
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-10 09:31 PDT by Mounir Lamouri (:mounir)
Modified: 2011-08-10 10:32 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.03 KB, patch)
2011-08-10 09:31 PDT, Mounir Lamouri (:mounir)
no flags Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-08-10 09:31:46 PDT
Created attachment 552097 [details] [diff] [review]
Patch v1
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-08-10 09:33:54 PDT
Why do we want this?
Comment 2 Mounir Lamouri (:mounir) 2011-08-10 09:34:49 PDT
To be able to push stuff in mozilla-central quite easily.
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-08-10 09:48:30 PDT
That approach would make it hard for people to test new APIs.  It's also not going to help keep the WIP code from rotting, since the MOZ_WEBAPI code would be invisible to patches landing on m-c.

I had an envisioned a workflow something like
 - iterate in bugs/patch queue/project branch until API X is ready for feedback
 - land on m-c, pref'd off
 - iterate moar until full spec and impl are done for X
 - pref on

What are the issues you see in an approach like that?
Comment 4 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-08-10 09:54:58 PDT
(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> That approach would make it hard for people to test new APIs.  It's also not
> going to help keep the WIP code from rotting, since the MOZ_WEBAPI code
> would be invisible to patches landing on m-c.

Right, these are my concerns as well.
Comment 5 Mounir Lamouri (:mounir) 2011-08-10 09:56:53 PDT
What about changing MOZ_WEBAPI to MOZ_WEBAPI_EXPERIMENTAL and move stuff out of MOZ_WEBAPI_EXPERIMENTAL as soon as they are ready for feedback.

My main concern is that a project branch might be more annoying than helpful (at least for the moment).
Comment 6 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-08-10 10:07:51 PDT
My instinct is to not bother with MOZ_WEBAPI/MOZ_WEBAPI_EXPERIMENTAL until we run across cases where there's a bunch of code we want to land on m-c that's not at all ready for feedback.  I'm not really sure what that kind of code would look like.

What code would you want to land on a project branch initially, if one were created?
Comment 7 Mounir Lamouri (:mounir) 2011-08-10 10:09:52 PDT
I have some code to send SMS and place calls that is rotting in my patch queue.
I guess I should just keep it here then...
Comment 8 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-08-10 10:16:28 PDT
How will it be less rotting if we stick it in the tree but don't try to build or test it?
Comment 9 Mounir Lamouri (:mounir) 2011-08-10 10:18:23 PDT
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #8)
> How will it be less rotting if we stick it in the tree but don't try to
> build or test it?

Boilerplate code bitrotes quickly and that often requires to fix the local patch queue.
Though, I believe I'm quite alone to think it would help so I will just mark it as WONTFIX.

Note You need to log in before you can comment on or make changes to this bug.