Closed Bug 677975 Opened 8 years ago Closed 8 years ago

Exception [nsIShellService.createShortcut] @ BookmarkHelper.js :: <TOP_LEVEL> :: line 92

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set

Tracking

(firefox8 fixed)

VERIFIED FIXED
Firefox 8
Tracking Status
firefox8 --- fixed

People

(Reporter: aaronmt, Assigned: mfinkle)

References

Details

Attachments

(1 file)

Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110810 Firefox/8.0a1 Fennec/8.0a1

STR:
1. about:
2. 'Add to Home Screen'

ER: Shortcut added to homescreen or menu item greyed out (or not shown).
AR: Nothing added.

Grey out the menu item for local pages? Not show it? Add the ability?
about:firefox worked for me
about:home too
Strange, new profile, about:home: added went to about: didn't add, went to about:fennec, didn't add.
(In reply to Aaron Train [:aaronmt] from comment #2)
> Strange, new profile, about:home: added went to about: didn't add, went to
> about:fennec, didn't add.

Any errors in console?
(In reply to Mark Finkle (:mfinkle) from comment #3)
> (In reply to Aaron Train [:aaronmt] from comment #2)
> > Strange, new profile, about:home: added went to about: didn't add, went to
> > about:fennec, didn't add.
> 
> Any errors in console?

None.
Ok scratch that, seeing this on other pages too, now with an error.

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIShellService.createShortcut]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/BookmarkHelper.js :: <TOP_LEVEL> :: line 92"  data: no]
chrome://browser/content/BookmarkHelper.js
94
Summary: No homescreen shortcut added for local about: pages → Exception [nsIShellService.createShortcut] @ BookmarkHelper.js :: <TOP_LEVEL> :: line 92
Blocks: 676293
No longer blocks: 677630
STR for error in comment #5 via http://www.pandora.com and then 'Add to Home Screen'
Attached patch patchSplinter Review
* pandora.com had a null title
* about: had a null faviicon

The patch uses fallbacks for missing data: URL for the title, default favicon for the icon

Using the URL as a fallback for the title kinda hurts, but even the stock browser does it. The stock browser does let you edit the bookmark title as soon as you make the bookmark, so it's not as bad there.
Assignee: nobody → mark.finkle
Attachment #552306 - Flags: review?(wjohnston)
Attachment #552306 - Flags: review?(wjohnston) → review+
http://hg.mozilla.org/mozilla-central/rev/3e0b5ad76bca
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Verified Fixed
Mozilla/5.0 (Android Linux armv7l; rv:9.0a1) Gecko/20110817 Firefox/9.0a1 Fennec/9.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.