677975 - Exception [nsIShellService.createShortcut] @ BookmarkHelper.js :: <TOP_LEVEL> :: line 92

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110810 Firefox/8.0a1 Fennec/8.0a1

STR:
1. about:
2. 'Add to Home Screen'

ER: Shortcut added to homescreen or menu item greyed out (or not shown).
AR: Nothing added.

Grey out the menu item for local pages? Not show it? Add the ability?

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

about:firefox worked for me
about:home too

Comment 2

[Aaron Train [:aaronmt]]

Strange, new profile, about:home: added went to about: didn't add, went to about:fennec, didn't add.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Strange, new profile, about:home: added went to about: didn't add, went to
> about:fennec, didn't add.

Any errors in console?

Comment 4

[Aaron Train [:aaronmt]]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> (In reply to Aaron Train [:aaronmt] from comment #2)
> > Strange, new profile, about:home: added went to about: didn't add, went to
> > about:fennec, didn't add.
> 
> Any errors in console?

None.

Comment 5

[Aaron Train [:aaronmt]]

Ok scratch that, seeing this on other pages too, now with an error.

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIShellService.createShortcut]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/BookmarkHelper.js :: <TOP_LEVEL> :: line 92"  data: no]
chrome://browser/content/BookmarkHelper.js
94

Comment 6

[Aaron Train [:aaronmt]]

STR for error in comment #5 via http://www.pandora.com and then 'Add to Home Screen'

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

* pandora.com had a null title
* about: had a null faviicon

The patch uses fallbacks for missing data: URL for the title, default favicon for the icon

Using the URL as a fallback for the title kinda hurts, but even the stock browser does it. The stock browser does let you edit the bookmark title as soon as you make the bookmark, so it's not as bad there.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mozilla-central/rev/3e0b5ad76bca

Comment 9

[Aaron Train [:aaronmt]]

Verified Fixed
Mozilla/5.0 (Android Linux armv7l; rv:9.0a1) Gecko/20110817 Firefox/9.0a1 Fennec/9.0a1