Closed Bug 678016 Opened 13 years ago Closed 13 years ago

Fix c++0x initializer list error found by clang

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla8

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file)

fix build with clang
1.29 KB, patch
jaas
: review+
Details | Diff | Splinter Review 
Add explict casts to short.
    ::Point is a OS provided data type, so we cannot change it. I could try adding
    a nsShortPoint type and have WidgetToScreenOffset to return it, but that
    is a virtual method used in other OSs, so doing the cast looked like the
    best solution.
Attachment #552188 - Flags: review?(mh+mozilla)
Attachment #552188 - Flags: review?(mh+mozilla) → review?(joshmoz)
Attachment #552188 - Flags: review?(joshmoz) → review+
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Pushed to inbound.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ff8535faf76e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: