The default bug view has changed. See this FAQ.

Fix c++0x initializer list error found by clang

RESOLVED FIXED in mozilla8

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

Trunk
mozilla8
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 552188 [details] [diff] [review]
fix build with clang

Add explict casts to short.
    ::Point is a OS provided data type, so we cannot change it. I could try adding
    a nsShortPoint type and have WidgetToScreenOffset to return it, but that
    is a virtual method used in other OSs, so doing the cast looked like the
    best solution.
Attachment #552188 - Flags: review?(mh+mozilla)
Attachment #552188 - Flags: review?(mh+mozilla) → review?(joshmoz)

Updated

6 years ago
Attachment #552188 - Flags: review?(joshmoz) → review+
Keywords: checkin-needed
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Pushed to inbound.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ff8535faf76e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.