678030 - Expose pci subsystem through GfxInfo

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This can help us know which vendor's are responsible for not updating drivers.

It looks we should be able to pull this info out of the same place as we get the device/vendor ids. e.g. "SUBSYS_........"

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Refactor ID parsing

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Report the subsys id in crashes

Comment 3

[Ali Juma [:ajuma]]

Comment on attachment 554390 [details] [diff] [review]
Report the subsys id in crashes

Review of attachment 554390 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/windows/GfxInfo.cpp
@@ +698,5 @@
>    note.AppendPrintf("AdapterVendorID: %04x, ", vendorID);
>    note.AppendPrintf("AdapterDeviceID: %04x, ", deviceID);
>    note.AppendPrintf("AdapterDriverVersion: ");
>    note.Append(NS_LossyConvertUTF16toASCII(adapterDriverVersionString));
> +  note.AppendPrintf("AdapterSubsysID: %08x", mAdapaterSubsysID);

Add a space (" Adapter...") so this doesn't run into the previous output.

@@ +721,5 @@
>      note.AppendPrintf("AdapterVendorID2: %04x, ", vendorID2);
>      note.AppendPrintf("AdapterDeviceID2: %04x, ", deviceID2);
>      note.AppendPrintf("AdapterDriverVersion2: ");
>      note.Append(NS_LossyConvertUTF16toASCII(adapterDriverVersionString2));
> +    note.AppendPrintf("AdapterSubsysID2: %08x", mAdapaterSubsysID2);

Add a space (" Adapter..") here too.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 554390 [details] [diff] [review]
Report the subsys id in crashes

r=me, just add the missing comma in the appnotes.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/c51e35b364e6
http://hg.mozilla.org/mozilla-central/rev/e6fc16452e52