Last Comment Bug 678030 - Expose pci subsystem through GfxInfo
: Expose pci subsystem through GfxInfo
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla9
Assigned To: Jeff Muizelaar [:jrmuizel]
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-10 13:29 PDT by Jeff Muizelaar [:jrmuizel]
Modified: 2011-08-21 11:29 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Refactor ID parsing (2.77 KB, patch)
2011-08-18 14:33 PDT, Jeff Muizelaar [:jrmuizel]
ajuma.bugzilla: review+
Details | Diff | Splinter Review
Report the subsys id in crashes (3.32 KB, patch)
2011-08-19 06:22 PDT, Jeff Muizelaar [:jrmuizel]
ajuma.bugzilla: review+
jacob.benoit.1: review+
Details | Diff | Splinter Review

Description Jeff Muizelaar [:jrmuizel] 2011-08-10 13:29:24 PDT
This can help us know which vendor's are responsible for not updating drivers.

It looks we should be able to pull this info out of the same place as we get the device/vendor ids. e.g. "SUBSYS_........"
Comment 1 Jeff Muizelaar [:jrmuizel] 2011-08-18 14:33:33 PDT
Created attachment 554212 [details] [diff] [review]
Refactor ID parsing
Comment 2 Jeff Muizelaar [:jrmuizel] 2011-08-19 06:22:23 PDT
Created attachment 554390 [details] [diff] [review]
Report the subsys id in crashes
Comment 3 Ali Juma [:ajuma] 2011-08-19 07:48:25 PDT
Comment on attachment 554390 [details] [diff] [review]
Report the subsys id in crashes

Review of attachment 554390 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/windows/GfxInfo.cpp
@@ +698,5 @@
>    note.AppendPrintf("AdapterVendorID: %04x, ", vendorID);
>    note.AppendPrintf("AdapterDeviceID: %04x, ", deviceID);
>    note.AppendPrintf("AdapterDriverVersion: ");
>    note.Append(NS_LossyConvertUTF16toASCII(adapterDriverVersionString));
> +  note.AppendPrintf("AdapterSubsysID: %08x", mAdapaterSubsysID);

Add a space (" Adapter...") so this doesn't run into the previous output.

@@ +721,5 @@
>      note.AppendPrintf("AdapterVendorID2: %04x, ", vendorID2);
>      note.AppendPrintf("AdapterDeviceID2: %04x, ", deviceID2);
>      note.AppendPrintf("AdapterDriverVersion2: ");
>      note.Append(NS_LossyConvertUTF16toASCII(adapterDriverVersionString2));
> +    note.AppendPrintf("AdapterSubsysID2: %08x", mAdapaterSubsysID2);

Add a space (" Adapter..") here too.
Comment 4 Benoit Jacob [:bjacob] (mostly away) 2011-08-19 08:55:17 PDT
Comment on attachment 554390 [details] [diff] [review]
Report the subsys id in crashes

r=me, just add the missing comma in the appnotes.

Note You need to log in before you can comment on or make changes to this bug.