Expose pci subsystem through GfxInfo

RESOLVED FIXED in mozilla9

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

Trunk
mozilla9
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
This can help us know which vendor's are responsible for not updating drivers.

It looks we should be able to pull this info out of the same place as we get the device/vendor ids. e.g. "SUBSYS_........"
(Assignee)

Comment 1

6 years ago
Created attachment 554212 [details] [diff] [review]
Refactor ID parsing
Attachment #554212 - Flags: review?(ajuma)
(Assignee)

Comment 2

6 years ago
Created attachment 554390 [details] [diff] [review]
Report the subsys id in crashes
Attachment #554390 - Flags: review?(bjacob)
Attachment #554390 - Flags: review?(ajuma)

Updated

6 years ago
Attachment #554212 - Flags: review?(ajuma) → review+

Comment 3

6 years ago
Comment on attachment 554390 [details] [diff] [review]
Report the subsys id in crashes

Review of attachment 554390 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/windows/GfxInfo.cpp
@@ +698,5 @@
>    note.AppendPrintf("AdapterVendorID: %04x, ", vendorID);
>    note.AppendPrintf("AdapterDeviceID: %04x, ", deviceID);
>    note.AppendPrintf("AdapterDriverVersion: ");
>    note.Append(NS_LossyConvertUTF16toASCII(adapterDriverVersionString));
> +  note.AppendPrintf("AdapterSubsysID: %08x", mAdapaterSubsysID);

Add a space (" Adapter...") so this doesn't run into the previous output.

@@ +721,5 @@
>      note.AppendPrintf("AdapterVendorID2: %04x, ", vendorID2);
>      note.AppendPrintf("AdapterDeviceID2: %04x, ", deviceID2);
>      note.AppendPrintf("AdapterDriverVersion2: ");
>      note.Append(NS_LossyConvertUTF16toASCII(adapterDriverVersionString2));
> +    note.AppendPrintf("AdapterSubsysID2: %08x", mAdapaterSubsysID2);

Add a space (" Adapter..") here too.
Attachment #554390 - Flags: review?(ajuma) → review+
Comment on attachment 554390 [details] [diff] [review]
Report the subsys id in crashes

r=me, just add the missing comma in the appnotes.
Attachment #554390 - Flags: review?(bjacob) → review+
http://hg.mozilla.org/mozilla-central/rev/c51e35b364e6
http://hg.mozilla.org/mozilla-central/rev/e6fc16452e52
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.