678051 - Fix c++0x initializer list error found by clang

Status: RESOLVED FIXED

(Core Graveyard :: Nanojit, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: fix build

Fix the build with clang in c++0x mode.
    
    Change the function msbSet32, lsbSet32, lsbSet64, msbSet64 to return
    unsigned ints. They are used in initializer lists that expect unsigned
    values.

Comment 1

[Nicholas Nethercote [inactive]]

Which initializer lists?  I wonder if those should be changed to expect 'int'.

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

   Register r = { (sizeof(RegisterMask) == 4) ? lsbSet32(mask) : lsbSet64(mask) }

in RegAlloc.h. Register is defined as

    struct Register {
        uint32_t n;     // the register number
    };

Do you think that should be a signed value?

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 552210 [details] [diff] [review]
fix build

Review of attachment 552210 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Rafael Ávila de Espíndola (:espindola) from comment #2)
>
> Do you think that should be a signed value?

It probably doesn't matter, really.

This has to land on nanojit-central, I'll do it on Monday.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Nicholas Nethercote [:njn] from comment #3)
> This has to land on nanojit-central, I'll do it on Monday.

(adding whiteboard chunk to hopefully keep anyone from landing this on m-c)

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

When can I expect this to land on nanojit-central?

Comment 6

[Nicholas Nethercote [inactive]]

I'll do it early next week.  Sorry for the delay.

Comment 7

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/projects/nanojit-central/rev/55c10227eece

Comment 8

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Nicholas, this fixes the build with clang. Is it possible to backport this patch to m-c?

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/90144e453538

Comment 10

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/90144e453538

Comment 11

[Nicholas Nethercote [inactive]]

Reopening because this hasn't landed on tamarin-redux.

Comment 12

[Tamarin Bot]

changeset: 6623:01094d3204f6
user:      Rafael Ávila de Espíndola <[e-mail]>
summary:   Bug 678051 - Fix c++0x initializer list error found by clang.  r=nnethercote.

http://hg.mozilla.org/tamarin-redux/rev/01094d3204f6