Closed
Bug 678051
Opened 14 years ago
Closed 13 years ago
Fix c++0x initializer list error found by clang
Categories
(Core Graveyard :: Nanojit, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: espindola, Assigned: espindola)
Details
(Whiteboard: [fixed-in-nanojit])
Attachments
(1 file)
|
5.07 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
Fix the build with clang in c++0x mode.
Change the function msbSet32, lsbSet32, lsbSet64, msbSet64 to return
unsigned ints. They are used in initializer lists that expect unsigned
values.
Attachment #552210 -
Flags: review?(mh+mozilla)
|
||
Updated•14 years ago
|
Attachment #552210 -
Flags: review?(mh+mozilla) → review?(nnethercote)
|
||
Comment 1•14 years ago
|
||
Which initializer lists? I wonder if those should be changed to expect 'int'.
|
Assignee | |
Comment 2•14 years ago
|
||
Register r = { (sizeof(RegisterMask) == 4) ? lsbSet32(mask) : lsbSet64(mask) }
in RegAlloc.h. Register is defined as
struct Register {
uint32_t n; // the register number
};
Do you think that should be a signed value?
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 552210 [details] [diff] [review]
fix build
Review of attachment 552210 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to Rafael Ávila de Espíndola (:espindola) from comment #2)
>
> Do you think that should be a signed value?
It probably doesn't matter, really.
This has to land on nanojit-central, I'll do it on Monday.
Attachment #552210 -
Flags: review?(nnethercote) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 4•14 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #3)
> This has to land on nanojit-central, I'll do it on Monday.
(adding whiteboard chunk to hopefully keep anyone from landing this on m-c)
Whiteboard: [checkin-needed for nanojit-central]
|
||
Updated•14 years ago
|
Assignee: nobody → respindola
|
|
Assignee | |
Comment 5•14 years ago
|
||
When can I expect this to land on nanojit-central?
|
|
||
Comment 6•14 years ago
|
||
I'll do it early next week. Sorry for the delay.
|
|
||
Comment 7•14 years ago
|
||
Keywords: checkin-needed
Whiteboard: [checkin-needed for nanojit-central] → [fixed-in-nanojit]
|
|
Assignee | |
Comment 8•14 years ago
|
||
Nicholas, this fixes the build with clang. Is it possible to backport this patch to m-c?
|
||
Comment 9•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•14 years ago
|
||
Whiteboard: [fixed-in-nanojit] → [fixed-in-nanojit][inbound]
|
|
||
Comment 11•14 years ago
|
||
Reopening because this hasn't landed on tamarin-redux.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 12•14 years ago
|
||
changeset: 6623:01094d3204f6
user: Rafael Ávila de Espíndola <respindola@mozilla.com>
summary: Bug 678051 - Fix c++0x initializer list error found by clang. r=nnethercote.
http://hg.mozilla.org/tamarin-redux/rev/01094d3204f6
|
|
||
Updated•13 years ago
|
Status: REOPENED → RESOLVED
Closed: 14 years ago → 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-nanojit][inbound] → [fixed-in-nanojit]
|
||
Updated•11 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•