678057 - Workers: overrideMimeType() removed from XHR, breaks web content, diverges from main-thread XHR

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Load http://media.tojicode.com/q3bsp/
 (2) Doesn't work, with error "request.overrideMimeType is not a function
Source File: http://media.tojicode.com/q3bsp/js/q3bsp_worker.js Line: 70"

bent tells me that sicking asked for this to be removed in bug 649537 as part of a larger plan to remove it from the spec.  OK, but (i) this breaks some part of the web; and (ii) it's still present in main-thread XHR, against spec.  This looks like a difficult battle to me, for what gain?

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

For what it's worth, I don't think I've asked for overrideMimeType to be removed (I did say that .multipart shouldn't be implemented as it's not part of the spec).

So yes, I suspect we need to implement this. I think that we should make it throw if called after .send() is called though since we can't implement it in a non-racy fashion after .send() is called.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #0)
> STR
>  (1) Load http://media.tojicode.com/q3bsp/

FWIW, I added a no-op overrideMimeType() and this page is still broken.  Might be separate bustage.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

This adds overrideMimeType back to worker XHR, with the caveat that we'll throw after Send() is called like we discussed on irc. I added a hefty comment explaining the problem. Also, I removed mozResponseArrayBuffer since it shouldn't have been there any more.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c5550a4ff624

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/c5550a4ff624

Could have used a better commit message.