Workers: overrideMimeType() removed from XHR, breaks web content, diverges from main-thread XHR

RESOLVED FIXED in mozilla8

Status

()

RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: cjones, Assigned: bent.mozilla)

Tracking

Trunk
mozilla8
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

STR
 (1) Load http://media.tojicode.com/q3bsp/
 (2) Doesn't work, with error "request.overrideMimeType is not a function
Source File: http://media.tojicode.com/q3bsp/js/q3bsp_worker.js Line: 70"

bent tells me that sicking asked for this to be removed in bug 649537 as part of a larger plan to remove it from the spec.  OK, but (i) this breaks some part of the web; and (ii) it's still present in main-thread XHR, against spec.  This looks like a difficult battle to me, for what gain?
tracking-firefox8: --- → ?
For what it's worth, I don't think I've asked for overrideMimeType to be removed (I did say that .multipart shouldn't be implemented as it's not part of the spec).

So yes, I suspect we need to implement this. I think that we should make it throw if called after .send() is called though since we can't implement it in a non-racy fashion after .send() is called.
(In reply to Chris Jones [:cjones] [:warhammer] from comment #0)
> STR
>  (1) Load http://media.tojicode.com/q3bsp/

FWIW, I added a no-op overrideMimeType() and this page is still broken.  Might be separate bustage.
Created attachment 552895 [details] [diff] [review]
Patch

This adds overrideMimeType back to worker XHR, with the caveat that we'll throw after Send() is called like we discussed on irc. I added a hefty comment explaining the problem. Also, I removed mozResponseArrayBuffer since it shouldn't have been there any more.
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #552895 - Flags: review?(jonas)
Summary: overrideMimeType() removed from Workers, breaks web content, diverges from main-thread XHR → Workers: overrideMimeType() removed from XHR, breaks web content, diverges from main-thread XHR
http://hg.mozilla.org/mozilla-central/rev/c5550a4ff624

Could have used a better commit message.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8

Updated

7 years ago
tracking-firefox8: ? → ---
You need to log in before you can comment on or make changes to this bug.