Closed Bug 678085 Opened 10 years ago Closed 10 years ago

Poll memory reporters before cycle collection, but no more than once per minute

Categories

(Toolkit :: Telemetry, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

Attachments

(1 file)

Telemetry current polls memory on idle. This is suboptimal due to introducing extra timers and polling memory at least interesting time. Ie if the browser is idle, memory use probably isn't changing.
Attachment #552254 - Flags: review?(nnethercote)
Comment on attachment 552254 [details] [diff] [review]
Poll memory memory before cycle collection, but no more than once per minute

Review of attachment 552254 [details] [diff] [review]:
-----------------------------------------------------------------

This is a good idea, pinging every 60s made me a bit uncomfortable.  r=me if you've actually confirmed (via logging) that the ping occurs when you expect it to :)
Attachment #552254 - Flags: review?(nnethercote) → review+
Summary: Improve memory stats → Poll memory memory before cycle collection, but no more than once per minute
Summary: Poll memory memory before cycle collection, but no more than once per minute → Poll memory reporters before cycle collection, but no more than once per minute
Does the cycle collector actually stop running when the browser is idle?  I should know the answer to that, but the CC triggers are mostly a mystery to me...
(In reply to Andrew McCreight [:mccr8] from comment #3)
> Does the cycle collector actually stop running when the browser is idle?  I
> should know the answer to that, but the CC triggers are mostly a mystery to
> me...

I know runs more frequently when the browser is active and rarely when it isn't(from observing telemetry histograms)
https://hg.mozilla.org/mozilla-central/rev/792eb2aff315
Assignee: nobody → tglek
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 1340134
No longer depends on: 1340134
You need to log in before you can comment on or make changes to this bug.