Closed
Bug 678085
Opened 13 years ago
Closed 13 years ago
Poll memory reporters before cycle collection, but no more than once per minute
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(1 file)
2.55 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
Telemetry current polls memory on idle. This is suboptimal due to introducing extra timers and polling memory at least interesting time. Ie if the browser is idle, memory use probably isn't changing.
Attachment #552254 -
Flags: review?(nnethercote)
Comment 1•13 years ago
|
||
Comment on attachment 552254 [details] [diff] [review]
Poll memory memory before cycle collection, but no more than once per minute
Review of attachment 552254 [details] [diff] [review]:
-----------------------------------------------------------------
This is a good idea, pinging every 60s made me a bit uncomfortable. r=me if you've actually confirmed (via logging) that the ping occurs when you expect it to :)
Attachment #552254 -
Flags: review?(nnethercote) → review+
Updated•13 years ago
|
Summary: Improve memory stats → Poll memory memory before cycle collection, but no more than once per minute
Assignee | ||
Comment 2•13 years ago
|
||
Whiteboard: [inbound]
Updated•13 years ago
|
Summary: Poll memory memory before cycle collection, but no more than once per minute → Poll memory reporters before cycle collection, but no more than once per minute
Comment 3•13 years ago
|
||
Does the cycle collector actually stop running when the browser is idle? I should know the answer to that, but the CC triggers are mostly a mystery to me...
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #3)
> Does the cycle collector actually stop running when the browser is idle? I
> should know the answer to that, but the CC triggers are mostly a mystery to
> me...
I know runs more frequently when the browser is active and rarely when it isn't(from observing telemetry histograms)
Comment 5•13 years ago
|
||
Assignee: nobody → tglek
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•