Use the original CID for the mock object in mockObjects.js

RESOLVED FIXED in mozilla8

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

(Blocks: 1 bug)

Trunk
mozilla8
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 552348 [details] [diff] [review]
Patch v1

Trying to find what was happening with the test in bug 463491, I realized mockObjects.js was creating a new CID but Components.classes[contractId] was still pointing to the original CID making Components.classes[contractId].createInstance() to fail if the previous factory was removed.

For unknown reasons, in the current state of the file, it will work but the original factory isn't removed. The test in bug 463491 was failing because .unregisterFactory() was called and it seems that as soon as it's done, you can't use mockObjects.js for the same factory. IOW, launching two times in a row the same test was always failing. The same way, unregistering the original factory before registering the new one was making the test to always fail.

It goes without saying: this patch went to try and the tree is green.
Attachment #552348 - Flags: review?(ehsan)
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
Attachment #552348 - Flags: review?(ehsan) → review+
(Assignee)

Comment 1

6 years ago
Thank you for the quick review!
Flags: in-testsuite+
Whiteboard: [needs review] → [inbound]
(Assignee)

Comment 2

6 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/5cc85a3730f8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.