Closed
Bug 678186
Opened 13 years ago
Closed 13 years ago
Make nsIMsgVCardService use charPtr instead of string for return values
Categories
(MailNews Core :: Address Book, defect)
MailNews Core
Address Book
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 8.0
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
1.56 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
The new python xpidl parser turns a [notxpcom] function return type of string into a const char*. Our code currently expects it to be a char*.
Therefore, we should use charPtr as it is clearer and works with both xpidl parsers.
I changed the uuid as I wasn't quite sure but thought it best anyway. Not going to request sr as this isn't an API change as such because it isn't an xpcom or scriptable function.
Attachment #552360 -
Flags: review?(dbienvenu)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 552360 [details] [diff] [review]
The fix
yeah, I don't see any reason to bump the uuid.
Attachment #552360 -
Flags: review?(dbienvenu) → review+
|
|
||
Comment 2•13 years ago
|
||
er, but bumping it is fine too.
|
Assignee | |
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 8.0
You need to log in
before you can comment on or make changes to this bug.
Description
•