Make nsIMsgVCardService use charPtr instead of string for return values

RESOLVED FIXED in Thunderbird 8.0

Status

MailNews Core
Address Book
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 8.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 552360 [details] [diff] [review]
The fix

The new python xpidl parser turns a [notxpcom] function return type of string into a const char*. Our code currently expects it to be a char*.

Therefore, we should use charPtr as it is clearer and works with both xpidl parsers.

I changed the uuid as I wasn't quite sure but thought it best anyway. Not going to request sr as this isn't an API change as such because it isn't an xpcom or scriptable function.
Attachment #552360 - Flags: review?(dbienvenu)

Comment 1

6 years ago
Comment on attachment 552360 [details] [diff] [review]
The fix

yeah, I don't see any reason to bump the uuid.
Attachment #552360 - Flags: review?(dbienvenu) → review+

Comment 2

6 years ago
er, but bumping it is fine too.
(Assignee)

Comment 3

6 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/eeef3926b5eb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 8.0
You need to log in before you can comment on or make changes to this bug.