Last Comment Bug 678186 - Make nsIMsgVCardService use charPtr instead of string for return values
: Make nsIMsgVCardService use charPtr instead of string for return values
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Address Book (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 8.0
Assigned To: Mark Banner (:standard8)
:
Mentors:
Depends on:
Blocks: 578790
  Show dependency treegraph
 
Reported: 2011-08-11 07:05 PDT by Mark Banner (:standard8)
Modified: 2011-08-12 14:34 PDT (History)
3 users (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
The fix (1.56 KB, patch)
2011-08-11 07:05 PDT, Mark Banner (:standard8)
mozilla: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8) 2011-08-11 07:05:09 PDT
Created attachment 552360 [details] [diff] [review]
The fix

The new python xpidl parser turns a [notxpcom] function return type of string into a const char*. Our code currently expects it to be a char*.

Therefore, we should use charPtr as it is clearer and works with both xpidl parsers.

I changed the uuid as I wasn't quite sure but thought it best anyway. Not going to request sr as this isn't an API change as such because it isn't an xpcom or scriptable function.
Comment 1 David :Bienvenu 2011-08-12 14:23:20 PDT
Comment on attachment 552360 [details] [diff] [review]
The fix

yeah, I don't see any reason to bump the uuid.
Comment 2 David :Bienvenu 2011-08-12 14:29:56 PDT
er, but bumping it is fine too.
Comment 3 Mark Banner (:standard8) 2011-08-12 14:34:16 PDT
Checked in: http://hg.mozilla.org/comm-central/rev/eeef3926b5eb

Note You need to log in before you can comment on or make changes to this bug.