Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[jsdbg2] Use CallArgs throughout Debugger.cpp

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

(Assignee)

Description

6 years ago
Per bug 672829 comment 69.
(Assignee)

Updated

6 years ago
Assignee: general → jorendorff
(Assignee)

Comment 1

6 years ago
Created attachment 552442 [details] [diff] [review]
part 1 - preliminary - v1

The CheckThis code is fake generality. It turns out only one class uses it. So I go ahead and specialize it.
Attachment #552442 - Flags: review?(luke)
(Assignee)

Comment 2

6 years ago
Created attachment 552444 [details] [diff] [review]
part 2 - move - v1

Move the newly specialized code just before its first use.
Attachment #552444 - Flags: review?(luke)
(Assignee)

Comment 3

6 years ago
Created attachment 552446 [details] [diff] [review]
part 3 - Debugger - v1
Attachment #552446 - Flags: review?(luke)
(Assignee)

Comment 4

6 years ago
Created attachment 552447 [details] [diff] [review]
part 4 - Script - v1
Attachment #552447 - Flags: review?(luke)
(Assignee)

Comment 5

6 years ago
Created attachment 552449 [details] [diff] [review]
part 5 - Frame - v1
Attachment #552449 - Flags: review?(luke)
(Assignee)

Comment 6

6 years ago
Created attachment 552487 [details] [diff] [review]
part 6 - Object - v1

That's it, 6 patches. It looks nicer this way.
Attachment #552487 - Flags: review?(luke)

Updated

6 years ago
Attachment #552442 - Flags: review?(luke) → review+

Comment 7

6 years ago
Comment on attachment 552444 [details] [diff] [review]
part 2 - move - v1

Review of attachment 552444 [details] [diff] [review]:
-----------------------------------------------------------------

I admire your patch-fu.  I should emulate this.
Attachment #552444 - Flags: review?(luke) → review+

Comment 8

6 years ago
Comment on attachment 552446 [details] [diff] [review]
part 3 - Debugger - v1

Review of attachment 552446 [details] [diff] [review]:
-----------------------------------------------------------------

So far we have been writing "CallArgs args = ...".  This is two chars more, but, as a nice side effect, "args[0]" reads nicely.  Grepping, there also seems to be "CallArgs call = ..." in a few places... I should fix this; it would be nice to have a canonical name.  r+ with s/ca/args/, or we can continue discussion.
Attachment #552446 - Flags: review?(luke) → review+

Updated

6 years ago
Attachment #552447 - Flags: review?(luke) → review+

Updated

6 years ago
Attachment #552449 - Flags: review?(luke) → review+

Updated

6 years ago
Attachment #552487 - Flags: review?(luke) → review+
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/users/jblandy_mozilla.com/jsdbg2/rev/eec543e3c644
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.