Last Comment Bug 678209 - Fix c++0x initializer list error found by clang
: Fix c++0x initializer list error found by clang
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: HTML: Parser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-11 08:58 PDT by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2011-08-23 01:31 PDT (History)
2 users (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix build (2.06 KB, patch)
2011-08-11 08:58 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
no flags Details | Diff | Splinter Review
updated patch (4.42 KB, patch)
2011-08-11 11:38 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
jonas: review+
Ms2ger: feedback+
Details | Diff | Splinter Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-08-11 08:58:26 PDT
Created attachment 552384 [details] [diff] [review]
fix build

Fix build with clang and c++0x.
    
    The aLength argument is used in
    
        CharacterDataChangeInfo info = {
          PR_TRUE,
          oldLength,
          oldLength,
          aLength
        };
    
    and the last field of CharacterDataChangeInfo is a PRUint32, so
    aLength should be one to for this to be valid c++0x.
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2011-08-11 09:04:54 PDT
Could you change the callers as well?
Comment 2 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-08-11 11:38:16 PDT
Created attachment 552451 [details] [diff] [review]
updated patch
Comment 3 Mounir Lamouri (:mounir) 2011-08-23 01:31:27 PDT
http://hg.mozilla.org/mozilla-central/rev/92ad56b41428

Note You need to log in before you can comment on or make changes to this bug.