Fix c++0x initializer list error found by clang

RESOLVED FIXED

Status

()

Core
HTML: Parser
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

Trunk
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 552384 [details] [diff] [review]
fix build

Fix build with clang and c++0x.
    
    The aLength argument is used in
    
        CharacterDataChangeInfo info = {
          PR_TRUE,
          oldLength,
          oldLength,
          aLength
        };
    
    and the last field of CharacterDataChangeInfo is a PRUint32, so
    aLength should be one to for this to be valid c++0x.
Attachment #552384 - Flags: review?(mh+mozilla)
Attachment #552384 - Flags: review?(mh+mozilla) → review?(hsivonen)
Could you change the callers as well?
Created attachment 552451 [details] [diff] [review]
updated patch
Attachment #552384 - Attachment is obsolete: true
Attachment #552384 - Flags: review?(hsivonen)
Attachment #552451 - Flags: review?(hsivonen)
Attachment #552451 - Flags: review?(hsivonen) → review?(Ms2ger)

Updated

6 years ago
Attachment #552451 - Flags: review?(hsivonen)
Attachment #552451 - Flags: review?(Ms2ger)
Attachment #552451 - Flags: feedback+
Attachment #552451 - Flags: review?(hsivonen) → review+
http://hg.mozilla.org/mozilla-central/rev/92ad56b41428
Assignee: nobody → respindola
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.