Closed Bug 678209 Opened 14 years ago Closed 14 years ago

Fix c++0x initializer list error found by clang

Categories

(Core :: DOM: HTML Parser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch fix build (obsolete) — Splinter Review
Fix build with clang and c++0x. The aLength argument is used in CharacterDataChangeInfo info = { PR_TRUE, oldLength, oldLength, aLength }; and the last field of CharacterDataChangeInfo is a PRUint32, so aLength should be one to for this to be valid c++0x.
Attachment #552384 - Flags: review?(mh+mozilla)
Attachment #552384 - Flags: review?(mh+mozilla) → review?(hsivonen)
Could you change the callers as well?
Attached patch updated patchSplinter Review
Attachment #552384 - Attachment is obsolete: true
Attachment #552384 - Flags: review?(hsivonen)
Attachment #552451 - Flags: review?(hsivonen)
Attachment #552451 - Flags: review?(hsivonen) → review?(Ms2ger)
Attachment #552451 - Flags: review?(hsivonen)
Attachment #552451 - Flags: review?(Ms2ger)
Attachment #552451 - Flags: feedback+
Assignee: nobody → respindola
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: