Closed
Bug 678209
Opened 14 years ago
Closed 14 years ago
Fix c++0x initializer list error found by clang
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(1 file, 1 obsolete file)
4.42 KB,
patch
|
sicking
:
review+
Ms2ger
:
feedback+
|
Details | Diff | Splinter Review |
Fix build with clang and c++0x.
The aLength argument is used in
CharacterDataChangeInfo info = {
PR_TRUE,
oldLength,
oldLength,
aLength
};
and the last field of CharacterDataChangeInfo is a PRUint32, so
aLength should be one to for this to be valid c++0x.
Attachment #552384 -
Flags: review?(mh+mozilla)
Updated•14 years ago
|
Attachment #552384 -
Flags: review?(mh+mozilla) → review?(hsivonen)
Comment 1•14 years ago
|
||
Could you change the callers as well?
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #552384 -
Attachment is obsolete: true
Attachment #552384 -
Flags: review?(hsivonen)
Attachment #552451 -
Flags: review?(hsivonen)
Assignee | ||
Updated•14 years ago
|
Attachment #552451 -
Flags: review?(hsivonen) → review?(Ms2ger)
Updated•14 years ago
|
Attachment #552451 -
Flags: review?(hsivonen)
Attachment #552451 -
Flags: review?(Ms2ger)
Attachment #552451 -
Flags: feedback+
Attachment #552451 -
Flags: review?(hsivonen) → review+
Comment 3•14 years ago
|
||
Assignee: nobody → respindola
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•