Last Comment Bug 678250 - Filter bounds rounded before scaling so small filters may be too large
: Filter bounds rounded before scaling so small filters may be too large
Status: RESOLVED FIXED
: testcase
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: Robert Longson
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-11 11:11 PDT by Robert Longson
Modified: 2011-08-16 03:17 PDT (History)
2 users (show)
Ms2ger: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (647 bytes, image/svg+xml)
2011-08-11 13:32 PDT, Robert Longson
no flags Details
patch (8.29 KB, patch)
2011-08-13 06:04 PDT, Robert Longson
no flags Details | Diff | Splinter Review
2nd try (10.31 KB, patch)
2011-08-14 07:01 PDT, Robert Longson
no flags Details | Diff | Splinter Review
patch (7.61 KB, patch)
2011-08-14 10:26 PDT, Robert Longson
roc: review+
Details | Diff | Splinter Review

Description Robert Longson 2011-08-11 11:11:43 PDT

    
Comment 1 Robert Longson 2011-08-11 13:32:32 PDT
Created attachment 552489 [details]
testcase
Comment 2 Robert Longson 2011-08-13 06:04:42 PDT
Created attachment 552866 [details] [diff] [review]
patch


The existing reftests need to change as they blend at the boundaries when the filter does not have integer bounds. The differences are not visible to the naked eye and the reftests that are testing other features should avoid this.
Comment 3 Robert Longson 2011-08-14 07:01:41 PDT
Created attachment 552975 [details] [diff] [review]
2nd try
Comment 4 Robert Longson 2011-08-14 10:26:01 PDT
Created attachment 552992 [details] [diff] [review]
patch


try seemed happy with this... http://tbpl.mozilla.org/?tree=Try&rev=145b560602f3
Comment 5 Robert Longson 2011-08-14 16:01:05 PDT
Comment on attachment 552992 [details] [diff] [review]
patch

still needs another tweak.
Comment 6 Robert Longson 2011-08-14 16:27:10 PDT
Comment on attachment 552992 [details] [diff] [review]
patch


thought about it some more and decided the thing I was worried about was right. Apologies for the bugspam.
Comment 8 :Ms2ger (⌚ UTC+1/+2) 2011-08-16 03:17:34 PDT
http://hg.mozilla.org/mozilla-central/rev/485f0838da93

Note You need to log in before you can comment on or make changes to this bug.