Closed Bug 678250 Opened 8 years ago Closed 8 years ago

Filter bounds rounded before scaling so small filters may be too large

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: longsonr, Assigned: longsonr)

Details

(Keywords: testcase)

Attachments

(2 files, 2 obsolete files)

No description provided.
Assignee: nobody → longsonr
Attached image testcase
Attached patch patch (obsolete) — Splinter Review
The existing reftests need to change as they blend at the boundaries when the filter does not have integer bounds. The differences are not visible to the naked eye and the reftests that are testing other features should avoid this.
Attached patch 2nd try (obsolete) — Splinter Review
Attachment #552866 - Attachment is obsolete: true
Attached patch patchSplinter Review
try seemed happy with this... http://tbpl.mozilla.org/?tree=Try&rev=145b560602f3
Attachment #552975 - Attachment is obsolete: true
Attachment #552992 - Flags: review?(roc)
Comment on attachment 552992 [details] [diff] [review]
patch

still needs another tweak.
Attachment #552992 - Flags: review?(roc)
Comment on attachment 552992 [details] [diff] [review]
patch


thought about it some more and decided the thing I was worried about was right. Apologies for the bugspam.
Attachment #552992 - Flags: review?(roc)
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/485f0838da93
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.