678250 - Filter bounds rounded before scaling so small filters may be too large

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Robert Longson [:longsonr]]

Attachment: testcase

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

The existing reftests need to change as they blend at the boundaries when the filter does not have integer bounds. The differences are not visible to the naked eye and the reftests that are testing other features should avoid this.

Comment 3

[Robert Longson [:longsonr]]

Attachment: 2nd try

Comment 4

[Robert Longson [:longsonr]]

Attachment: patch

try seemed happy with this... http://tbpl.mozilla.org/?tree=Try&rev=145b560602f3

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 552992 [details] [diff] [review]
patch

still needs another tweak.

Comment 6

[Robert Longson [:longsonr]]

Comment on attachment 552992 [details] [diff] [review]
patch


thought about it some more and decided the thing I was worried about was right. Apologies for the bugspam.

Comment 7

[Robert Longson [:longsonr]]

pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/485f0838da93

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/485f0838da93