Last Comment Bug 678457 - jsscan.cpp should not assert that cx->isExceptionPending() on errors.
: jsscan.cpp should not assert that cx->isExceptionPending() on errors.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla8
Assigned To: Igor Bukanov
:
:
Mentors:
Depends on:
Blocks: 636224
  Show dependency treegraph
 
Reported: 2011-08-12 01:13 PDT by Igor Bukanov
Modified: 2011-08-14 05:05 PDT (History)
8 users (show)
khuey: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (124.16 KB, patch)
2011-08-12 01:20 PDT, Igor Bukanov
no flags Details | Diff | Splinter Review
fix for real (905 bytes, patch)
2011-08-12 13:11 PDT, Igor Bukanov
luke: review+
Details | Diff | Splinter Review

Description Igor Bukanov 2011-08-12 01:13:30 PDT
As Out-Of-Memory errors does not create any exceptions and rather silently propagate failures, the isExceptionPending() asserts added in the bug 636224 to jsscan.cpp are not correct.
Comment 1 Igor Bukanov 2011-08-12 01:20:50 PDT
Created attachment 552616 [details] [diff] [review]
fix

The patch just removes the assert. The test case will appear in the bug 671702. There with smaller chunks and with a test case that limits the max GC heap size to 128K I trigger the assert reliably.
Comment 2 Luke Wagner [:luke] 2011-08-12 10:24:01 PDT
Comment on attachment 552616 [details] [diff] [review]
fix

Did you perhaps attach the wrong patch?  This one has lots of... stuff.
Comment 3 Igor Bukanov 2011-08-12 13:11:15 PDT
Created attachment 552742 [details] [diff] [review]
fix for real

here is the right patch
Comment 5 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-14 05:05:49 PDT
http://hg.mozilla.org/mozilla-central/rev/779fe0db869b

Note You need to log in before you can comment on or make changes to this bug.