The default bug view has changed. See this FAQ.

jsscan.cpp should not assert that cx->isExceptionPending() on errors.

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

unspecified
mozilla8
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

905 bytes, patch
luke
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
As Out-Of-Memory errors does not create any exceptions and rather silently propagate failures, the isExceptionPending() asserts added in the bug 636224 to jsscan.cpp are not correct.
(Assignee)

Comment 1

6 years ago
Created attachment 552616 [details] [diff] [review]
fix

The patch just removes the assert. The test case will appear in the bug 671702. There with smaller chunks and with a test case that limits the max GC heap size to 128K I trigger the assert reliably.
Attachment #552616 - Flags: review?(luke)

Comment 2

6 years ago
Comment on attachment 552616 [details] [diff] [review]
fix

Did you perhaps attach the wrong patch?  This one has lots of... stuff.
Attachment #552616 - Flags: review?(luke)
(Assignee)

Comment 3

6 years ago
Created attachment 552742 [details] [diff] [review]
fix for real

here is the right patch
Attachment #552616 - Attachment is obsolete: true
Attachment #552742 - Flags: review?(luke)

Updated

6 years ago
Attachment #552742 - Flags: review?(luke) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/779fe0db869b
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/779fe0db869b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.