67856 - nsSocketTransport can't always get to nsIPrompt

Status: VERIFIED INVALID

(Core :: Networking, defect)

Description

[Mike Pinkerton (not reading bugmail)]

instrument nsSocketTransport::doAsyncRead with the following:

NS_ASSERTION ( mCallbacks, "no mCallbacks!");
if ( mCallbacks ) {
  nsCOMPtr<nsIPrompt> prompt;
  mCallbacks->GetInterface ( NS_GET_IID(nsIPrompt), getter_AddRefs(prompt) );
  NS_ASSERTION ( prompt, "Channel doesn't have a prompt!!!" );
}

after browsing for a while, reading imap mail, etc, i see both asserts at 
different times while pages are loading, the app is quitting, etc.

Comment 1

[Marek Z. Jeziorek]

changing target milestone to Mozilla 0.9

Comment 2

[Marek Z. Jeziorek]

I think I messed up the process: 
* reverting to -- as milestone
* proposing Mozilla0.9 as the target milestone
* adding embed keyword

Comment 3

[Doug Turner (:dougt)]

Now invalid.  The socket transport does not need to throw a nsIPrompt anymore.  
Just progress.

Comment 4

[Brian Ryner (not reading)]

dougt, can you elaborate on that?  I think the main point of this bug is that we
need to set mCallbacks on all our channels so that we can parent dialogs
properly, not necessarily to use the nsIPrompt interface.

Comment 5

[Doug Turner (:dougt)]

Brian, the nsSocketTransport is not a channel.  There isn't any need for 
nsSocketTransport to directly call on a nsIPrompt.  If any notification need to 
fire, it should be the Channel which owns the socket transport.

Comment 6

[Mike Pinkerton (not reading bugmail)]

the |mCallbacks| member was removed when dougt landed his rewrite, so there's 
nothing to worry about here anymore.

Comment 7

[benc]

VERIFIED, per mike.