678579 - Tearing node assignment out of sreg

Status: VERIFIED FIXED

(Cloud Services :: Server: Registration, defect)

Description

[Toby Elliott [:telliott]]

Attachment: Pulls all node provisioning from sreg

Since we're launching nodes before or simultaneous with the sreg launch, and node requests are never going to hit reg, there's no need to support nodes in sreg and we can pull the extra dependency.

Comment 1

[Tarek Ziadé (:tarek)]

Comment on attachment 552724 [details] [diff] [review]
Pulls all node provisioning from sreg

The change looks good so +r

I did not see the tests you're removed here, in the standalone node project. Are we covering the use tests we cover in those test there ?

Like, the node exhaustion issue was a fix we've added after we've hit that issue on stage.

Comment 2

[Toby Elliott [:telliott]]

Yes, exhaustion is covered in this test: http://hg.mozilla.org/services/server-node-assignment/file/56157749145a/mozsvcnodes/tests/test_web.py#l68

(6th request)

Leaving this open and not checking it in yet, since we had to abort nodes push for this week.

Comment 3

[Toby Elliott [:telliott]]

Nodes has pushed, and the bulk of nodes code is gone from sreg. There's still a function there, since we need to conform to the API, but it's not likely to matter and the deps have been cleaned up in http://hg.mozilla.org/services/server-sreg/rev/7d7e866100f8