678656 - fix some debug only warnings in js/src/jsemit.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Robert Sayre]

jsemit.cpp: In function ‘JSBool js_EmitTree(JSContext*, JSCodeGenerator*, JSParseNode*)’:
jsemit.cpp:5183: warning: ‘tps.TempPopScope::savedScopeStmt’ may be used uninitialized in this function
jsemit.cpp:5183: warning: ‘tps.TempPopScope::savedBlockBox’ may be used uninitialized in this function
jsemit.cpp:6697: warning: ‘tps.TempPopScope::savedScopeStmt’ may be used uninitialized in this function
jsemit.cpp:6697: warning: ‘tps.TempPopScope::savedBlockBox’ may be used uninitialized in this function
jsemit.cpp: In function ‘JSBool EmitSwitch(JSContext*, JSCodeGenerator*, JSParseNode*, JSStmtInfo*)’:
jsemit.cpp:3177: warning: ‘tps.TempPopScope::savedScopeStmt’ may be used uninitialized in this function
jsemit.cpp:3177: warning: ‘tps.TempPopScope::savedBlockBox’ may be used uninitialized in this function

Comment 1

[Robert Sayre]

Attachment: add the other two member variables

Comment 2

[Jason Orendorff [:jorendorff]]

This warning isn't debug-only. I only see it in opt builds. I'm going to get rid of the #ifdef as well and just always initialize these.

I pushed this to jsdbg2 branch. In hindsight that's a pretty silly thing to have done, but it'll land with jsdbg2, I think this weekend. If it doesn't, or if jsdbg2 bounces, I'll push it to mozilla-inbound separately.

Comment 3

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/mozilla-central/rev/3cc01fa9d8fb