Closed Bug 678686 Opened 9 years ago Closed 9 years ago
package-manifest should has $(GLOBAL
Although I have added ANGLE support for Win64, ANGLE files isn't included in Win64 installer. Because package-manifest isn't updated even if autoconf.mk is changed. We should add $(GLOBAL_DEPS) dependency to package-manifest/package-manifest.in.
Assignee: nobody → m_kato
Status: NEW → ASSIGNED
Comment on attachment 552825 [details] [diff] [review] fix I'm not technically a reviewer, but this is obvious enough for me to happily attach my name to it. Alternatively you can use "FORCE" as a dep here, like mobile does. either way, I think http://mxr.mozilla.org/mozilla-central/source/mobile/installer/Makefile.in#99 should match while you're doing this. (but I won't dare review the potential dropping of the FORCE dep there) ALSO would appreciate (but not required for this bug) to patch the three places in comm-central (you can take an rs+=me for those changes if you do them) http://mxr.mozilla.org/comm-central/source/mail/installer/Makefile.in#95 http://mxr.mozilla.org/comm-central/source/suite/installer/Makefile.in#129 http://mxr.mozilla.org/comm-central/source/calendar/installer/Makefile.in#90
Attachment #552825 - Flags: review+
Attachment #553971 - Flags: review?(bugspam.Callek)
landed to inbound http://hg.mozilla.org/integration/mozilla-inbound/rev/1b6414e98c4e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Attachment #553971 - Flags: review?(bugspam.Callek) → review+
landed to c-c http://hg.mozilla.org/comm-central/rev/9ae88a03c47d
You need to log in before you can comment on or make changes to this bug.