678796 - TCBS cron test is time zone dependent

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Lonnen :lonnen]

unittest/cron/testTopCrashesBySignature.py fails when you run it ~ 1 am PDT. Rhelmer was able to build without problems by changing his VM's clock. It may be a difference between UTC and local time.

Comment 1

[Lonnen :lonnen]

Making this a blocker since we Jenkins won't let us push a build unless it is passing all tests.

Comment 2

[Lonnen :lonnen]

Attachment: *whistles*

This won't fix the actual problem, but it will remove the failing test so we can push the build to stage.

It's a low risk failure, so I recommend we push this to branch only and then unblock this (but leave the bug unresolved.)

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 552943 [details] [diff] [review]
*whistles*

+1, branch-only

Comment 4

[Lonnen :lonnen]

landed in branch-only as r3435 (http://code.google.com/p/socorro/source/detail?r=3435)

Comment 5

[Laura Thomson :laura]

We'll actually fix this the right way in 2.3, I think.

Comment 6

[Robert Helmer [:rhelmer]]

If we keep bumping this, we can probably just get rid of old-tcbs and rm this test :)

Comment 7

[Laura Thomson :laura]

Old TCBS is only relevant to Camino after this: new action is "skip the test from 2.3.2 on and hope for Camino one day or something"

Comment 8

[Robert Helmer [:rhelmer]]

https://github.com/mozilla/socorro/pull/93

Comment 9

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8597592ccf21d1c5ce015de4b5a9dbc0f6f63f65
Merge pull request #93 from rhelmer/bug678796-oldtcbs-unit-test-busted

bug 678796 - disable failing unit test