TCBS cron test is time zone dependent

RESOLVED FIXED in 2.3.2

Status

Socorro
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: lonnen, Assigned: rhelmer)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
unittest/cron/testTopCrashesBySignature.py fails when you run it ~ 1 am PDT. Rhelmer was able to build without problems by changing his VM's clock. It may be a difference between UTC and local time.
(Reporter)

Comment 1

7 years ago
Making this a blocker since we Jenkins won't let us push a build unless it is passing all tests.
Severity: normal → blocker
(Reporter)

Comment 2

7 years ago
Created attachment 552943 [details] [diff] [review]
*whistles*

This won't fix the actual problem, but it will remove the failing test so we can push the build to stage.

It's a low risk failure, so I recommend we push this to branch only and then unblock this (but leave the bug unresolved.)
Attachment #552943 - Flags: review?(rhelmer)
(Assignee)

Comment 3

7 years ago
Comment on attachment 552943 [details] [diff] [review]
*whistles*

+1, branch-only
Attachment #552943 - Flags: review?(rhelmer) → review+
(Reporter)

Comment 4

7 years ago
landed in branch-only as r3435 (http://code.google.com/p/socorro/source/detail?r=3435)
(Reporter)

Updated

7 years ago
Severity: blocker → normal

Comment 5

7 years ago
We'll actually fix this the right way in 2.3, I think.
Target Milestone: 2.2 → 2.3
(Assignee)

Comment 6

7 years ago
If we keep bumping this, we can probably just get rid of old-tcbs and rm this test :)
Target Milestone: 2.3 → 2.3.1

Updated

7 years ago
Target Milestone: 2.3.1 → 2.3.2

Comment 7

7 years ago
Old TCBS is only relevant to Camino after this: new action is "skip the test from 2.3.2 on and hope for Camino one day or something"
Assignee: nobody → rhelmer
(Assignee)

Comment 8

7 years ago
https://github.com/mozilla/socorro/pull/93
Status: NEW → ASSIGNED

Comment 9

7 years ago
Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8597592ccf21d1c5ce015de4b5a9dbc0f6f63f65
Merge pull request #93 from rhelmer/bug678796-oldtcbs-unit-test-busted

bug 678796 - disable failing unit test
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.