678800 - content :hover state should not be affected by moving mouse into context menu

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[blinky]

Cannot search or copy the original text in the  info bubble in the google translate.


When you select the text in the info bubble, 
and then pressing the right button, then choose "Search Google for" 
The search results do not appear.
http://s449.photobucket.com/albums/qq217/movh/?action=view&current=7fb52802.mp4



Search results  appear in Firefox 3.6
http://s449.photobucket.com/albums/qq217/movh/?action=view&current=c4f3679c.mp4




When you select the text in the info bubble, 
and then pressing the right button, then choose 'Copy' 
Cannot copy and paste text.
http://s449.photobucket.com/albums/qq217/movh/?action=view&current=dd1754a9.mp4



Can copy and paste the text in Firefox 3.6
http://s449.photobucket.com/albums/qq217/movh/?action=view&current=9b5109fe.mp4

Comment 1

[Alice0775 White]

Very similar to Bug 616331, but different regression range.

Confirmed on
http://hg.mozilla.org/mozilla-central/rev/9698a1031317
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110813 Firefox/8.0a1 ID:20110813030746

Regression window(cached m-c hourly):
Works:
http://hg.mozilla.org/mozilla-central/rev/714faf8ec149
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100524 Minefield/3.7a5pre ID:20100524162132
Fails:
http://hg.mozilla.org/mozilla-central/rev/2e4105f85be9
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100524 Minefield/3.7a5pre ID:20100524172122
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=714faf8ec149&tochange=2e4105f85be9

Triggered by:
0c440c656ada	Mats Palmgren — Bug 39098 - Elements with visibility:hidden, visibility:collapse, or display:none get copied to the clipboard. r=dbaron

Comment 2

[Alice0775 White]

Attachment: test html

Comment 3

[Boris Zbarsky [:bzbarsky]]

The patch for bug 39098 handles visibility incorrectly.  Just because a node is visibility:hidden does not mean that all its descendants are also hidden.

Mats, could you please take a look?

Comment 4

[Mats Palmgren (inactive)]

(In reply to Boris Zbarsky (:bz) from comment #3)
> The patch for bug 39098 handles visibility incorrectly.  Just because a node
> is visibility:hidden does not mean that all its descendants are also hidden.

Testcase?  The following works fine for me:
<div style="visibility:hidden">
hidden
<span style="visibility:visible">visible</span>
</div>

This bug is about display:none though, for which the behavior is the expected -
invisible content should not be copied.

I think bug here is that opening the context menu affects the hover state of the
content.  I think it would work better if it didn't.  Chrome, Opera and IE
don't reset the hover state when moving the mouse over the context menu.

Comment 5

[Boris Zbarsky [:bzbarsky]]

> The following works fine for me:

In that it copies the text?  Looks like it, yes; my reading of the code suggested it would not work....

> I think bug here is that opening the context menu affects the hover state of the
> content.

As in it goes out of hover and the little popup disappears?

Comment 6

[Mats Palmgren (inactive)]

> In that it copies the text?

Yes, select all + copy-paste, gives the result "visible".
I think the key is that we only check visibility on #text.
(except some table elements)

> As in it goes out of hover and the little popup disappears?

Yes, other UAs don't do that.

Comment 7

[Alex Keybl [:akeybl]]

I've just confirmed this issue on Beta 11 on OS X Lion. Mats - can you take a look?

Comment 8

[Mats Palmgren (inactive)]

There's no bug in selection or in the serialization of it.

The bug here is that opening the context menu affects the hover state of the
content.  I think it would work better if it didn't.  Chrome, Opera and IE
don't reset the hover state when moving the mouse over the context menu.

Comment 11

[Alice0775 White]

WFM 
https://hg.mozilla.org/mozilla-central/rev/37f04460ddb76d6ef4e7c32a8a6b2fbc44cb8776
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 ID:20160423030220