678847 - "ABORT: Update current interval recursion depth exceeded threshold" with <svg:animate>

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox-debug when loaded)

###!!! ABORT: Update current interval recursion depth exceeded threshold: 'PR_FALSE', file content/smil/nsSMILTimedElement.cpp, line 1949

Does not crash in opt.

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Brian Birtles (:birtles)]

Attachment: Part 1 - Crash test

Crash test--same as attachment 553005 [details] but packed up as a crash test

Comment 3

[Brian Birtles (:birtles)]

Attachment: Part 2 - Proposed patch v1a

Proposed patch.

Comment 4

[Brian Birtles (:birtles)]

Attachment: Alternative approach

Alternative patch just for reference

Comment 5

[Brian Birtles (:birtles)]

Comment on attachment 555940 [details] [diff] [review]
Part 2 - Proposed patch v1a

I need to rethink this a bit

Comment 6

[Brian Birtles (:birtles)]

Attachment: Part 2 - Proposed patch v1b

It's generally not a good idea to file patches as you're going out the door but this should be better than the last attempt anyway.

Comment 7

[Daniel Holbert [:dholbert]]

Comment on attachment 555945 [details] [diff] [review]
Part 2 - Proposed patch v1b

Looks good.

Comment 8

[Brian Birtles (:birtles)]

Pushed to m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/7a01e603335d
http://hg.mozilla.org/integration/mozilla-inbound/rev/246f74de583c

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/7a01e603335d
http://hg.mozilla.org/mozilla-central/rev/246f74de583c