Closed
Bug 678921
Opened 13 years ago
Closed 13 years ago
Use EqualsLiteral and LowerCaseEqualsLiteral
Categories
(MailNews Core :: Networking, defect)
MailNews Core
Networking
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 9.0
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(1 file, 2 obsolete files)
|
15.69 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•13 years ago
|
Attachment #553077 -
Flags: review?(dbienvenu)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 553077 [details] [diff] [review]
Fix
this doesn't compile:
- else if (value.Equals(NS_LITERAL_STRING("plaintext").get()))
+ else if (value.EqualsLiteral("plaintext"()))
you don't want the last (), most likely...
Attachment #553077 -
Flags: review?(dbienvenu) → review-
|
|
Assignee | |
Comment 2•13 years ago
|
||
I am sorry. I have fixed it but I did attach a wrong patch.
Assignee: nobody → hiikezoe
Attachment #553077 -
Attachment is obsolete: true
Attachment #553278 -
Flags: review?(dbienvenu)
|
|
||
Comment 3•13 years ago
|
||
prev patch didn't compile in the eudora import code, but this one does compile, and passes tests...
Attachment #553278 -
Attachment is obsolete: true
Attachment #553278 -
Flags: review?(dbienvenu)
Attachment #553588 -
Flags: review?(dbienvenu)
|
|
||
Updated•13 years ago
|
Attachment #553588 -
Flags: review?(dbienvenu) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
You need to log in
before you can comment on or make changes to this bug.
Description
•