Closed Bug 678921 Opened 13 years ago Closed 13 years ago

Use EqualsLiteral and LowerCaseEqualsLiteral

Categories

(MailNews Core :: Networking, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 9.0

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Fix (obsolete) — Splinter Review
      No description provided.
Attachment #553077 - Flags: review?(dbienvenu)
Comment on attachment 553077 [details] [diff] [review]
Fix

this doesn't compile:

-                else if (value.Equals(NS_LITERAL_STRING("plaintext").get()))
+                else if (value.EqualsLiteral("plaintext"()))

you don't want the last (), most likely...
Attachment #553077 - Flags: review?(dbienvenu) → review-
Attached patch Fix the mistake (obsolete) — Splinter Review
I am sorry. I have fixed it but I did attach a wrong patch.
Assignee: nobody → hiikezoe
Attachment #553077 - Attachment is obsolete: true
Attachment #553278 - Flags: review?(dbienvenu)
prev patch didn't compile in the eudora import code, but this one does compile, and passes tests...
Attachment #553278 - Attachment is obsolete: true
Attachment #553278 - Flags: review?(dbienvenu)
Attachment #553588 - Flags: review?(dbienvenu)
Attachment #553588 - Flags: review?(dbienvenu) → review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/af6e4968813a
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: