Use EqualsLiteral and LowerCaseEqualsLiteral

RESOLVED FIXED in Thunderbird 9.0

Status

MailNews Core
Networking
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

unspecified
Thunderbird 9.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Updated

7 years ago
Attachment #553077 - Flags: review?(dbienvenu)

Comment 1

7 years ago
Comment on attachment 553077 [details] [diff] [review]
Fix

this doesn't compile:

-                else if (value.Equals(NS_LITERAL_STRING("plaintext").get()))
+                else if (value.EqualsLiteral("plaintext"()))

you don't want the last (), most likely...
Attachment #553077 - Flags: review?(dbienvenu) → review-
(Assignee)

Comment 2

7 years ago
Created attachment 553278 [details] [diff] [review]
Fix the mistake

I am sorry. I have fixed it but I did attach a wrong patch.
Assignee: nobody → hiikezoe
Attachment #553077 - Attachment is obsolete: true
Attachment #553278 - Flags: review?(dbienvenu)

Comment 3

7 years ago
Created attachment 553588 [details] [diff] [review]
patch that compiles

prev patch didn't compile in the eudora import code, but this one does compile, and passes tests...
Attachment #553278 - Attachment is obsolete: true
Attachment #553278 - Flags: review?(dbienvenu)
Attachment #553588 - Flags: review?(dbienvenu)

Updated

7 years ago
Attachment #553588 - Flags: review?(dbienvenu) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/af6e4968813a
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
You need to log in before you can comment on or make changes to this bug.