Closed Bug 678922 Opened 9 years ago Closed 9 years ago

Telemeterize the "storage/sqlite" memory reporter

Categories

(Toolkit :: Telemetry, defect)

Product:
Toolkit
Component:
Telemetry
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: njn, Assigned: njn)

Details

(Whiteboard: [MemShrink:P2][inbound])

Attachments

(1 file)

patch
3.11 KB, patch
khuey
: review+
taras.mozilla
: feedback+
Details | Diff | Splinter Review 
SQLite's memory usage can get really big, esp. if things go wrong (e.g. busted profiles and/or badly written add-ons).  Telemetry info about it would be useful.

(Also, "explicit/layout/all" no longer exists, so it should be un-telemeterized.  It never struck me as a very useful reporter to have in telemetry, it's rarely interesting.)
Whiteboard: [MemShrink]
(In reply to Nicholas Nethercote [:njn] from comment #0)
> (Also, "explicit/layout/all" no longer exists, so it should be
> un-telemeterized.  It never struck me as a very useful reporter to have in
> telemetry, it's rarely interesting.)

It was renamed to layout/arenas.
Attached patch patch — — Splinter Review 
I added MEMORY_STORAGE_SQLITE and removed MEMORY_LAYOUT_ALL.
Attachment #553339 - Flags: review?(khuey)
Comment on attachment 553339 [details] [diff] [review]
patch

Does the telemetry backend handle changing reporters like this?
Attachment #553339 - Flags: review?(khuey)
Attachment #553339 - Flags: review+
Attachment #553339 - Flags: feedback?(tglek)
Attachment #553339 - Flags: feedback?(tglek) → feedback+
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #3)

> Does the telemetry backend handle changing reporters like this?

yes. It's freeform json.
Whiteboard: [MemShrink] → [MemShrink:P2]
http://hg.mozilla.org/mozilla-central/rev/e3a6de4920d0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.