678922 - Telemeterize the "storage/sqlite" memory reporter

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Nicholas Nethercote [inactive]]

SQLite's memory usage can get really big, esp. if things go wrong (e.g. busted profiles and/or badly written add-ons).  Telemetry info about it would be useful.

(Also, "explicit/layout/all" no longer exists, so it should be un-telemeterized.  It never struck me as a very useful reporter to have in telemetry, it's rarely interesting.)

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Nicholas Nethercote [:njn] from comment #0)
> (Also, "explicit/layout/all" no longer exists, so it should be
> un-telemeterized.  It never struck me as a very useful reporter to have in
> telemetry, it's rarely interesting.)

It was renamed to layout/arenas.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: patch

I added MEMORY_STORAGE_SQLITE and removed MEMORY_LAYOUT_ALL.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 553339 [details] [diff] [review]
patch

Does the telemetry backend handle changing reporters like this?

Comment 4

[(dormant account)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #3)

> Does the telemetry backend handle changing reporters like this?

yes. It's freeform json.

Comment 5

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e3a6de4920d0

Comment 6

[Marco Bonardo [:mak] (Away 10-21 August)]

http://hg.mozilla.org/mozilla-central/rev/e3a6de4920d0