678930 - ICS calendar fails when connection temporarily unavailable

Status: RESOLVED FIXED

(Calendar :: Provider: ICS/WebDAV, defect)

Description

[Matthew Mecca [:mmecca]]

Reloading a remote ics calendar with the connection unavailable will sometimes fail with 

Error: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIHttpChannel.responseStatus]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: file:///media/Data/mozilla/obj-i686-pc-linux-gnu-comm-miramar/mozilla/dist/xpi-stage/lightning/components/calICSCalendar.js :: <TOP_LEVEL> :: line 920"  data: no]
Source File: file:///media/Data/mozilla/obj-i686-pc-linux-gnu-comm-miramar/mozilla/dist/xpi-stage/lightning/components/calICSCalendar.js
Line: 920

This can leave the calendar in a locked state, and prevent further operations even if the connection becomes available again.

Comment 1

[Matthew Mecca [:mmecca]]

Attachment: Fix v1

Allow provider to fail gracefully when encountering potentially temporary connection issues on load

Comment 3

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 553095 [details] [diff] [review]
Fix v1

Review of attachment 553095 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp with the following nits. Feel free to push to all three branches.

::: calendar/providers/ics/calICSCalendar.js
@@ +944,5 @@
>          // 404: Not Found
>          // This is a new calendar. Shouldn't try to parse it. But it also
>          // isn't a failure, so don't throw.
> +        if (responseStatus == 404) {
> +            cal.LOG("[calICSCalendar] 404: Not Found.");

I'd suggest being more verbose on the log message here since a file not found isn't really a bad thing for new calendars.

Comment 4

[Matthew Mecca [:mmecca]]

Attachment: Fix v2

De-bitrotted, more verbose messages.

Comment 5

[Matthew Mecca [:mmecca]]

Pushed to comm-central - http://hg.mozilla.org/comm-central/rev/184b6ee5fc26

Comment 6

[Matthew Mecca [:mmecca]]

I'll push to comm-beta after the merge.

Comment 7

[Matthew Mecca [:mmecca]]

Pushing to comm-aurora per Bug 543323 comment #12

Comment 8

[Matthew Mecca [:mmecca]]

Pushed to comm-aurora - http://hg.mozilla.org/releases/comm-aurora/rev/b8bad8be49ca