Closed
Bug 678945
Opened 14 years ago
Closed 14 years ago
Remove duplicate InitPrompts function and only load mail-offline.js once
Categories
(SeaMonkey :: MailNews: General, defect)
SeaMonkey
MailNews: General
Tracking
(seamonkey2.5 fixed)
RESOLVED
FIXED
seamonkey2.5
| Tracking | Status | |
|---|---|---|
| seamonkey2.5 | --- | fixed |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file)
|
3.07 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
As Neil said over in Bug 671554 comment 5:
> function InitPrompts()
I wonder why we define this again in mailWindowOverlay.js, since mailWindowOverlay.xul already includes mail-offline.js - in fact, messenger.xul then includes it again...
This patch:
* Removes loading of mail-offline.js from messenger.xul as it already happens indirectly from the overlaying by mailWindowOverlay.xul
* Removes the duplication of function InitPrompts from mailWindowOverlay.js
* Removes the duplication of var declaration from mailWindowOverlay.js
Attachment #553131 -
Flags: review?(neil)
|
||
Updated•14 years ago
|
Attachment #553131 -
Attachment description: De-duple offlinepromptsbudle → De-duple offlinepromptsbundle
Attachment #553131 -
Flags: review?(neil) → review+
Comment on attachment 553131 [details] [diff] [review]
De-duple offlinepromptsbundle [Checked in: Comment 1]
http://hg.mozilla.org/comm-central/rev/00239d93ef1b
Attachment #553131 -
Attachment description: De-duple offlinepromptsbundle → De-duple offlinepromptsbundle [Checked in: Comment 1]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
status-seamonkey2.5:
--- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5
You need to log in
before you can comment on or make changes to this bug.
Description
•