678970 - Use $user and $cgi instead of Bugzilla->user and Bugzilla->cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

Attachment: patch, v1

This is part of a code cleanup process I started to remove very old code. Before Bugzilla 2.22, Bugzilla->login didn't return anything. Since 2.22, it returns the user object. As all *.cgi scripts call Bugzilla->login, we already have the current user object in hands. No need to call Bugzilla->user anymore within the whole script. I also fixed places which still uses Bugzilla->cgi instead of the already defined $cgi object.

Comment 1

[Max Kanat-Alexander]

Cool. Just to check, does any of this touch code that is inside of subroutines in .cgi files? Because "my $user" and "my $cgi" from outside of the subroutines can't be safely used inside of subroutines under mod_perl.

Comment 2

[Frédéric Buclin]

I checked them all one by one, don't worry. :)

Comment 3

[Max Kanat-Alexander]

(In reply to Frédéric Buclin from comment #2)
> I checked them all one by one, don't worry. :)

  Okay, sounds good to me, then. :-)

Comment 4

[Tiago Mello [:timello]]

Comment on attachment 553155 [details] [diff] [review]
patch, v1

Review of attachment 553155 [details] [diff] [review]:
-----------------------------------------------------------------

Bug.add_comment is also using Bugzilla->user instead of $user.

Otherwise it looks right.

::: userprefs.cgi
@@ +51,4 @@
>      ($vars->{'realname'}) = $dbh->selectrow_array(
>          "SELECT realname FROM profiles WHERE userid = ?", undef, $user->id);
>  
> +    if (Bugzilla->params->{'allowemailchange'} && $user->authorizer->can_change_email) {

This line is a bit long.

Comment 5

[Frédéric Buclin]

(In reply to Tiago Mello [:timello] from comment #4)
> Bug.add_comment is also using Bugzilla->user instead of $user.

Nice catch, thanks! I will fix it on checkin.

Comment 6

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified buglist.cgi
modified colchange.cgi
modified config.cgi
modified createaccount.cgi
modified describekeywords.cgi
modified editclassifications.cgi
modified editvalues.cgi
modified editwhines.cgi
modified enter_bug.cgi
modified process_bug.cgi
modified query.cgi
modified sanitycheck.cgi
modified show_bug.cgi
modified showdependencygraph.cgi
modified summarize_time.cgi
modified userprefs.cgi
modified Bugzilla/WebService/Bug.pm
Committed revision 7930.