678992 - remove /system/etc/hosts from tegras and check for it during cleanup/config

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

as per:
https://bugzilla.mozilla.org/show_bug.cgi?id=662936#c64

we should remove /system/etc/hosts from the tegras.  Lets do this in staging and get a few runs of all the tests first before rolling this out.

Ideally this would be a step added to imaging the tegras, but we can roll this out via SUTAgent also to fix our existing tegras.

Here is some sample code that handles the removal of the file:
import devicemanager

dm = devicemanager.DeviceManager('192.168.1.101', 20701)

if dm.fileExists('/system/etc/hosts'):
  dm.sendCMD(['exec mount -o remount,rw -t yaffs2 /dev/block/mtdblock3 /system'])
  dm.sendCMD(['exec rm /system/etc/hosts'])
  if dm.fileExists('/system/etc/hosts'):
    print "failed to remove /system/etc/hosts"
  else:
    print "successfully removed hosts file, we can test!!!"
  dm.reboot()

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

we should be able to throw a check into our cleanup.py/config.py if this file exists.  If so, we can delete and reboot, otherwise we just continue on.

This would result in a one time hit on all our tegras, then after that about 1 second of overhead while we check for the file.  

We should still adjust our tegra imaging documents to include removing this file.

Comment 2

[Mike Taylor [:bear]]

assigning to aki so he can "sanity check" our thought that this is something to do across all of the tegras via the cleanup step.

Comment 3

[Mike Taylor [:bear]]

Attachment: add hosts file removal to cleanup step

realized I should just give aki a patch to review instead of relying oh his paranormal powers to read my mind

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 553608 [details] [diff] [review]
add hosts file removal to cleanup step

I think we do after a resolution change (though it's in an if statement so may not always run) and after installation by default (though it's assumed it'll happen).

As long as one of those two things (or something else after this step) reboots, this looks good.

Comment 5

[Mike Taylor [:bear]]

Comment on attachment 553608 [details] [diff] [review]
add hosts file removal to cleanup step

committed changeset 1726:983b1cca058e

Comment 6

[Mike Taylor [:bear]]

deployed to all of the foopies and watched tegra-032 have a good cleanup.py run

Comment 7

[Mike Taylor [:bear]]

except for "normal" tegra environment related purples, it's been a solid green for the most part.

closing bug as FIXED