Last Comment Bug 679019 - Initialize Error classes more simply and less generically
: Initialize Error classes more simply and less generically
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla9
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-15 10:18 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-08-18 03:54 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
1 - Make initialization of Error clearer (5.21 KB, patch)
2011-08-15 10:22 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
jorendorff: review+
Details | Diff | Splinter Review
2 - Make initialization of *Error clearer as well (4.25 KB, patch)
2011-08-15 10:23 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
jorendorff: review+
Details | Diff | Splinter Review
3 - Combine initialization for Error and for *Error into a single function (7.36 KB, patch)
2011-08-15 10:24 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
jorendorff: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2011-08-15 10:18:16 PDT

    
Comment 1 Jeff Walden [:Waldo] (remove +bmo to email) 2011-08-15 10:22:10 PDT
Created attachment 553211 [details] [diff] [review]
1 - Make initialization of Error clearer

Note that there are three patches coming here, and there's some widening of code and algorithms and then some later collapsing.
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2011-08-15 10:23:06 PDT
Created attachment 553212 [details] [diff] [review]
2 - Make initialization of *Error clearer as well
Comment 3 Jeff Walden [:Waldo] (remove +bmo to email) 2011-08-15 10:24:22 PDT
Created attachment 553213 [details] [diff] [review]
3 - Combine initialization for Error and for *Error into a single function

Note You need to log in before you can comment on or make changes to this bug.