679091 - GCC 4.6 build warning: "gfxASurface.cpp:533:16: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]"

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning reported by GCC 4.6:
{
gfx/thebes/gfxASurface.cpp: In member function ‘void gfxASurface::FastMovePixels(const nsIntRect&, const nsIntPoint&)’:
gfx/thebes/gfxASurface.cpp:533:16: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]
}

Looks like this variable was unused in the patch that added it:
====
+void
+gfxASurface::MovePixels(const nsIntRect& aSourceRect,
+                        const nsIntPoint& aDestTopLeft)
+{
+    gfxIntSize size = GetSize();
+    nsIntRect dest(aDestTopLeft, aSourceRect.Size());
+    // Assume that our cairo backend already knows how to properly
+    // self-copy.  gfxASurface subtypes whose backend can't self-copy
+    // need their own implementations, or their backends need to be
+    // fixed.
+    nsRefPtr<gfxContext> ctx = new gfxContext(this);
+    ctx->SetOperator(gfxContext::OPERATOR_SOURCE);
+    nsIntPoint srcOrigin = dest.TopLeft() - aSourceRect.TopLeft();
+    ctx->SetSource(this, gfxPoint(srcOrigin.x, srcOrigin.y));
+    ctx->Rectangle(gfxRect(dest.x, dest.y, dest.width, dest.height));
+    ctx->Fill();
+}
https://hg.mozilla.org/mozilla-central/rev/173971a4af7e
====

Begone with you, unused variable!

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: remove unused variable

Comment 2

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4d9fe0a94ba2

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/4d9fe0a94ba2