679096 - Replace FILTER url_quote by FILTER uri

Status: RESOLVED FIXED

(Testopia :: Integrations, defect)

Description

[Justin Judd]

User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.112 Safari/535.1

Steps to reproduce:

I have a test environment with Bugzilla 4.1.3 in place.  I copied over the Testopia files from the latest revision(rev 648) and manually applied the patch for 4.0 as some of the Bugzilla files that it patches have changed.  I then ran checksetup.pl.  


Actual results:

When accessing the Bugzilla/Testopia the following page is presented.
"
Bugzilla has suffered an internal error. Please save this page and send it to root@bugzilla with details of what you were doing at the time this message appeared.

URL: http://###.###.###.###/

Template->process() failed twice.
First error: undef error - url_quote: filter not found
Second error: undef error - url_quote: filter not found
"


Expected results:

The Bugzilla main page should have been presented, containing the Testopia links on it.

Comment 1

[reg]

I have encountered the same issue today with same error message.
Testopia was working with older version, but when i tried to install testopia
for Bugzilla 4.1.3 i'm encountering the same issue as above.

Comment 2

[Peter Florijn]

Same here on Bugzilla 4.2 release

Comment 3

[Peter Florijn]

Template->process() failed twice.
First error: undef error - url_quote: filter not found
Second error: undef error - url_quote: filter not found

Seems url_quote is deprecated

Found this in Bugzilla message 398701 with fix

find . *-type f -name "*.tmpl" -exec replace 'FILTER url_quote' 'FILTER uri' -- {} \;*

Executed this from the Testopia extensions directory and this updated a number of template files:

./template/en/default/hook/bug/create/create-end.html.tmpl converted
./template/en/default/hook/bug/edit-after_custom_fields.html.tmpl converted
./template/en/default/hook/bug/process/results-links.html.tmpl converted
./template/en/default/hook/global/common-links-link-row.html.tmpl converted
./template/en/default/hook/global/useful-links-end.html.tmpl converted
./template/en/default/testopia/reports/build-coverage.html.tmpl converted
./template/en/default/testopia/reports/completion.html.tmpl converted
./template/en/default/testopia/reports/execution.html.tmpl converted
./template/en/default/testopia/reports/priority-breakdown.html.tmpl converted
./template/en/default/testopia/reports/report-table.html.tmpl converted
./template/en/default/testopia/reports/report.html.tmpl converted
./template/en/default/testopia/reports/status.html.tmpl converted
./template/en/default/testopia/tag/list.html.tmpl converted

I now get the index page.

Comment 4

[Ryan Castro]

I can confirm this solution at least gives me a working index page on on Windows, Bugzilla 4.2. I changed the files mentioned manually using notepad in windows (note, your changes case sensitive). Thanks for sharing.

Comment 5

[Frédéric Buclin]

Peter: would you agree to attach a patch with these changes? :)

Comment 6

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 7

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 8

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 9

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 10

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 11

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 12

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 13

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 14

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 15

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 16

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 17

[Peter Florijn]

Attachment: Patch for url_quote: filter not found error

Comment 18

[rojanu]

Attachment: url_quote to uri singular patch

This is Peters patches bound together for easy committing.

LpSolit, would you be able review this so we can make some progress.
Thanks

Comment 19

[Frédéric Buclin]

Peter, next time, attach a single patch with all related changes in it, as rojanu did. Much easier to review and to commit. :)

Comment 20

[Frédéric Buclin]

Comment on attachment 613195 [details] [diff] [review]
url_quote to uri singular patch

Thanks for the patch. r=LpSolit

Comment 21

[Frédéric Buclin]

Attachment: fake

(fake attachment to obsolete all patches at once; ignore this)

Comment 22

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/extensions/testopia/trunk/
modified extensions/Testopia/template/en/default/hook/bug/edit-after_custom_fields.html.tmpl
modified extensions/Testopia/template/en/default/hook/bug/create/create-end.html.tmpl
modified extensions/Testopia/template/en/default/hook/bug/process/results-links.html.tmpl
modified extensions/Testopia/template/en/default/hook/global/common-links-link-row.html.tmpl
modified extensions/Testopia/template/en/default/hook/global/useful-links-end.html.tmpl
modified extensions/Testopia/template/en/default/testopia/reports/build-coverage.html.tmpl
modified extensions/Testopia/template/en/default/testopia/reports/completion.html.tmpl
modified extensions/Testopia/template/en/default/testopia/reports/execution.html.tmpl
modified extensions/Testopia/template/en/default/testopia/reports/priority-breakdown.html.tmpl
modified extensions/Testopia/template/en/default/testopia/reports/report-table.html.tmpl
modified extensions/Testopia/template/en/default/testopia/reports/report.html.tmpl
modified extensions/Testopia/template/en/default/testopia/reports/status.html.tmpl
modified extensions/Testopia/template/en/default/testopia/tag/list.html.tmpl
Committed revision 649.