679120 - Allow negative numbers for integer prefs in mobile about:config

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Steps to reproduce:
1. Open about:config in Fennec
2. Search for "tablet"
3. Try to set "browser.ui.layout.tablet" to -1

Expected results: Pressing the "Down" spinner button will set the pref to -1.
Actual results: Once the pref is zero, the down spinner button has no effect.

<setting type="integer"> uses min="0" by default.  We need to override this in about:config to allow setting prefs with negative numbers.

Comment 1

[Lucas Rocha (:lucasr)]

Comment on attachment 553255 [details] [diff] [review]
patch

Review of attachment 553255 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good (assuming it's safe to do so on every integer prefs).

Comment 2

[Matt Brubeck (:mbrubeck)]

(In reply to Lucas Rocha from comment #1)
> Looks good (assuming it's safe to do so on every integer prefs).

about:config only knows whether a pref is string, integer, or boolean; beyond that it can't usefully restrict the values.  So it should just allow all values of the correct type, as it does in desktop Firefox.

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9ec7a44e2ab

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/d9ec7a44e2ab

Comment 4

[Aaron Train [:aaronmt]]

Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110818 Firefox/9.0a1 Fennec/9.0a1