Initial history is not correctly synced

RESOLVED WONTFIX

Status

Pancake
Add-On
--
blocker
RESOLVED WONTFIX
7 years ago
7 years ago

People

(Reporter: st3fan, Assigned: maxim zhilyaev)

Tracking

Details

(Whiteboard: [qa^])

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
The problem was that instead of guids and visititemids, an array index was pushed on the changedGuids dictionary. The attached patch queries for the last history items for the last 2 months and pushes guid/visititemid on the changedGuids dict. The result of the query is grouped by guid so that multiple visits for the same item are correctly merged into one.
(Reporter)

Comment 1

7 years ago
Created attachment 553260 [details] [diff] [review]
Patch for uploading initial history items
Looks good, except that we should use a pref for the number of months we can go back in history.
(Reporter)

Comment 3

7 years ago
Created attachment 553497 [details] [diff] [review]
Better patch that actually works correctly

This is a better patch.
(Reporter)

Updated

7 years ago
Attachment #553497 - Flags: review?(fabrice)
Comment on attachment 553497 [details] [diff] [review]
Better patch that actually works correctly

Review of attachment 553497 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, but we must not hard code the number of months we go back.
Attachment #553497 - Flags: review?(fabrice) → review-
Severity: normal → blocker
Assignee: fabrice → maksik
Assignee: maksik → mzhilyaev
(Assignee)

Comment 5

7 years ago
I believe the current version of addon behaves correctly.  If the user data is lost the BE server sends "reset-request" in which case addon a) sends reset request to the server, and b) moves last-get-data-date to 0 which re-starts sending data to the server from the beginning of time.

I suggest marking this bug as designed (WONTFIX)

IFF there's a specific feature request to allow user to specify how much data (or how far back in history) addon may collect, this should be tracked under a separate bug filed as enhancement request.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.