679133 - Initial history is not correctly synced

Status: RESOLVED WONTFIX

(Pancake Graveyard :: Add-On, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The problem was that instead of guids and visititemids, an array index was pushed on the changedGuids dictionary. The attached patch queries for the last history items for the last 2 months and pushes guid/visititemid on the changedGuids dict. The result of the query is grouped by guid so that multiple visits for the same item are correctly merged into one.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Patch for uploading initial history items

Comment 2

[[:fabrice] Fabrice Desré]

Looks good, except that we should use a pref for the number of months we can go back in history.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Better patch that actually works correctly

This is a better patch.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 553497 [details] [diff] [review]
Better patch that actually works correctly

Review of attachment 553497 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine, but we must not hard code the number of months we go back.

Comment 5

[maxim zhilyaev]

I believe the current version of addon behaves correctly.  If the user data is lost the BE server sends "reset-request" in which case addon a) sends reset request to the server, and b) moves last-get-data-date to 0 which re-starts sending data to the server from the beginning of time.

I suggest marking this bug as designed (WONTFIX)

IFF there's a specific feature request to allow user to specify how much data (or how far back in history) addon may collect, this should be tracked under a separate bug filed as enhancement request.