679138 - argv past script argument should not be interpreted as options

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Leary [:cdleary] (not checking bugmail)]

Expected behavior:

<<EOF
print(uneval(arguments))
EOF

$ ./js foo.js -q
["-q"]

Comment 1

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Script arg terminates options.

This also gives us the ability to make a |--| option for people passing |-f| if we cared.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 553267 [details] [diff] [review]
Script arg terminates options.

Review of attachment 553267 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/jsoptparse.h
@@ +78,5 @@
>  
>      virtual ~Option() = 0;
>  
> +    void setTerminatesOptions(bool enabled) { terminatesOptions = enabled; }
> +    bool getTerminatesOptions() const { return terminatesOptions; }

I think this reads better as just "terminatesOptions()" but get is fine too

Comment 3

[Ed Morley [:emorley]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ee787d92a2e1

http://hg.mozilla.org/mozilla-central/rev/ee787d92a2e1