679196 - Mem leak when preferred effect is set for drag and drop

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Brian R. Bondy [:bbondy]]

Bug 296528 introduced a memory leak with the following code in nsClipboard.cpp:

>   nsresult loadResult = nsClipboard::GetNativeDataOffClipboard(
>       pIDataSource, 0, ::RegisterClipboardFormat(CFSTR_PREFERREDDROPEFFECT), nsnull, &tempOutData, &tempDataLen);

tempOutData should be freed.

The memory leak is only hit when Windows deicdes to set a preferred effect on the data source, which doesn't happen often.

Windows does set it sometimes when dragging from Windows explorer and always when dragging from an FTP site.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Fixes memleak for when preferred effect memory is allcoated

Neil this is the mem leak you noticed, so I'm setting you as the reviewer :)

Comment 2

[Brian R. Bondy [:bbondy]]

Pushed to try:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=a34d0baace5c

Comment 3

[(no longer active)]

Seems like this fell through the cracks!  I rebased and landed it on inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/3f3380cfd15a

Comment 4

[Brian R. Bondy [:bbondy]]

> Seems like this fell through the cracks!  

Nah I'm just behind on pushing my tasks out.  I had about 30 ready to go  in but didn't have level 3 commit access until about 3 weeks ago.  My rate of task creation vs pushing is fixed now so I should eventually get caught up :)

Comment 5

[Ed Morley [:emorley]]

If you want a hand catching up, there is always checkin-needed :-)

Comment 6

[Brian R. Bondy [:bbondy]]

nah mostly I need to run through try and verify things are ok.  I'm getting close to caught up already.  I try to put about 10 to try per week to get caught up right now.  This bug and the related drag and drop series of bugs are next on my list, but all hands in the way :)

Comment 7

[Brian R. Bondy [:bbondy]]

> I rebased and landed it on inbound

Thanks by the way :)

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/3f3380cfd15a