The default bug view has changed. See this FAQ.

Mem leak when preferred effect is set for drag and drop

RESOLVED FIXED in mozilla9

Status

()

Core
Widget: Win32
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

({mlk})

Trunk
mozilla9
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Bug 296528 introduced a memory leak with the following code in nsClipboard.cpp:

>   nsresult loadResult = nsClipboard::GetNativeDataOffClipboard(
>       pIDataSource, 0, ::RegisterClipboardFormat(CFSTR_PREFERREDDROPEFFECT), nsnull, &tempOutData, &tempDataLen);

tempOutData should be freed.

The memory leak is only hit when Windows deicdes to set a preferred effect on the data source, which doesn't happen often.

Windows does set it sometimes when dragging from Windows explorer and always when dragging from an FTP site.

Updated

6 years ago
Blocks: 296528
No longer depends on: 296528
(Assignee)

Comment 1

6 years ago
Created attachment 553669 [details] [diff] [review]
Fixes memleak for when preferred effect memory is allcoated

Neil this is the mem leak you noticed, so I'm setting you as the reviewer :)
Attachment #553669 - Flags: review?(neil)

Updated

6 years ago
Attachment #553669 - Flags: review?(neil) → review+
(Assignee)

Comment 2

6 years ago
Pushed to try:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=a34d0baace5c
Seems like this fell through the cracks!  I rebased and landed it on inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/3f3380cfd15a
Target Milestone: --- → mozilla9
Keywords: mlk
Whiteboard: [MemShrink]
(Assignee)

Comment 4

6 years ago
> Seems like this fell through the cracks!  

Nah I'm just behind on pushing my tasks out.  I had about 30 ready to go  in but didn't have level 3 commit access until about 3 weeks ago.  My rate of task creation vs pushing is fixed now so I should eventually get caught up :)
If you want a hand catching up, there is always checkin-needed :-)
(Assignee)

Comment 6

6 years ago
nah mostly I need to run through try and verify things are ok.  I'm getting close to caught up already.  I try to put about 10 to try per week to get caught up right now.  This bug and the related drag and drop series of bugs are next on my list, but all hands in the way :)
(Assignee)

Comment 7

6 years ago
> I rebased and landed it on inbound

Thanks by the way :)
https://hg.mozilla.org/mozilla-central/rev/3f3380cfd15a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.